tags:

views:

2705

answers:

4

I can see there's a Sorting object with a quickSort method on it.

Can someone provide a code example of using it, sorting an array of object of arbitrary type? It looks like I need to pass in an impl of the Orderable trait, but I am unsure of the syntax.

Also, I would prefer answers doing this the 'scala way'. I know I can just use a Java library.

+2  A: 
val array = Array((for(i <- 0 to 10) yield scala.util.Random.nextInt): _*)
scala.util.Sorting.quickSort(array)

Scala's "default" array is a mutable data structure, very close to Java's Array. Generally speaking, that means an "array" is not very Scala-ish, even as mutable data structures go. It serves a purpose, though. If array is the right data type for your need, then that is how you sort it. There are other sorting methods on object Sorting, by the way.

I think I just realized what your question is... you don't need to pass any implicit parameter (it's implicit, after all). That parameter exists to say that there must be some way to convert the type K into an Ordered[K]. These definitions already exist for Scala's classes, so you don't need them.

For an arbitrary class you can define it this way:

scala> case class Person(name: String)
defined class Person

scala> val array = Array(Person("John"), Person("Mike"), Person("Abe"))
array: Array[Person] = Array(Person(John), Person(Mike), Person(Abe))

scala> scala.util.Sorting.quickSort(array)
<console>:11: error: no implicit argument matching parameter type (Person) => Ordered[Person] was found.
       scala.util.Sorting.quickSort(array)
                                   ^
scala> class OrderedPerson(val person: Person) extends Ordered[Person] {
     | def compare(that: Person) = person.name.compare(that.name)
     | }
defined class OrderedPerson

scala> implicit def personToOrdered(p: Person) = new OrderedPerson(p)
personToOrdered: (p: Person)OrderedPerson

scala> scala.util.Sorting.quickSort(array)

scala> array
res8: Array[Person] = Array(Person(Abe), Person(John), Person(Mike))

Now, if Person was Ordered to begin with, this wouldn't be a problem:

scala> case class Person(name: String) extends Ordered[Person] {
     | def compare(that: Person) = name.compare(that.name)
     | }
defined class Person

scala> val array = Array(Person("John"), Person("Mike"), Person("Abe"))
array: Array[Person] = Array(Person(John), Person(Mike), Person(Abe))

scala>  scala.util.Sorting.quickSort(array)

scala> array
res10: Array[Person] = Array(Person(Abe), Person(John), Person(Mike))
Daniel
Apologies, I wasn't clear: I need to sort an array of objects of arbitrary type, not numbers.
Dan Gravell
+3  A: 

Sorting.quickSort declares functions for taking an Array of numbers or Strings, but I'm assuming you mean you want to sort a list of objects of your own classes?

The function I think you're looking at is

quickSort [K](a : Array[K])(implicit view$1 : (K) => Ordered[K]) : Unit

Which, if I'm reading this right, means that the objects in the Array must have the Ordered trait. So your class must extend Ordered (or must mix it in), and therefore must implement the compare method of that trait.

So to rip off an example from the book:

class MyClass(n: Int) extends Ordered[MyClass] {
   ...
  def compare(that: MyClass) =
    this.n - that.n
}

So given an Array[MyClass], then Sorting.quickSort should work.

skaffman
Yeah, that's the one. It makes sense now you point it out. How would I 'mix it in'?
Dan Gravell
See edit. You either *extend* like my example, or use "class MyClass extends OtherClass with Ordered[MyClass]", which is a mix-in.
skaffman
Thanks. I think I'll do the latter.
Dan Gravell
Hooray! My first accepted Scala answer!
skaffman
Not to be pedantic, but...your class need not extend Ordered, it is sufficient that there is a view (also know as an implicit conversion) in scope from your class to something that does extend Ordered.
Kim
+4  A: 

If you just want to sort things, but aren't married to the Sorting object in particular, you can use the sort method of List. It takes a comparison function as an argument, so you can use it on whatever types you'd like:

List("Steve", "Tom", "John", "Bob").sort((e1, e2) => (e1 compareTo e2) < 0)

List(1, 4, 3, 2).sort((e1, e2) => (e1 < e2))

Lists probably qualify as "more scalaish" than arrays.

From the scala api docs:

def sort(lt : (A, A) => Boolean) : List[A]

Sort the list according to the comparison function <(e1: a, e2: a) =>

Boolean, which should be true iff e1 is smaller than e2.

Peter Recore
Hmm, so List has a sort method, but Array doesn't. How unsatisfyingly irregular. I expect that sort of nonsense from the Java API, but not Scala.
skaffman
I'm too much of a scala newb to know for sure, but it may be a necessary evil, given that Scala is maintaining compatibility with all the java stuff. On the other hand, Scala does so much magic, it seems normal enough to want it to do even more!
Peter Recore
List(...) sort { _ < _ } would be more idiomatic.
Daniel Spiewak
It's also worth noting that String does define (through an implicit conversion) the < method: "daniel" < "chris" == false
Daniel Spiewak
+1  A: 

While the accepted answer isn't wrong, the quicksort method provides more flexibility than that. I wrote this example for you.

import System.out.println
import scala.util.Sorting.quickSort

class Foo(x:Int) {
def get = x
}

//a wrapper around Foo that implements Ordered[Foo]
class OrdFoo(x:Foo) extends Ordered[Foo] {
def compare(that:Foo) = x.get-that.get
}
//another wrapper around Foo that implements Ordered[Foo] in a different way
class OrdFoo2(x:Foo) extends Ordered[Foo] {
def compare(that:Foo) = that.get-x.get
}
//an implicit conversion from Foo to OrdFoo
implicit def convert(a:Foo) = new OrdFoo(a)

//an array of Foos
val arr = Array(new Foo(2),new Foo(3),new Foo(1))

//sorting using OrdFoo
scala.util.Sorting.quickSort(arr)
arr foreach (a=>println(a.get))
/*
This will print:
1
2
3
*/

//sorting using OrdFoo2
scala.util.Sorting.quickSort(arr)(new OrdFoo2(_))
arr foreach (a=>println(a.get))
/*
This will print:
3
2
1
*/

This shows how implicit and explicit conversions from Foo to some class extending Ordered[Foo] can be used to get different sort orders.

Kim