Best practices for remote peer code review

Question

I recently completed my first large project in a new framework (Django). To get feedback on my code, I am scheduling time for an expert programmer to review my code with me remotely. We plan to use VoIP for the voice communication; what is the best way for us to visually walk through my code together (e.g. a particular screen-sharing application)? Any other recommendations for the best way to conduct this session?

Note: I am looking for something easy/inexpensive to set up, since this might be a one-time event.

Answer 1

http://www.yuuguu.com/ or http://showmypc.com/ might work well for a one-off thing.

Answer 2

You're probably better served if it's not interactive. Instead ask the reviewer to make notes, to which you can refer as you refactor. The note could be added as comments in the source code.

Answer 3

Copilot.com

Answer 4

We use GoTo Meeting where I work.

The good:

• VOIP or dial-in voice
• share your screen with up to 15 people.
• seems to run more smoothly/interactively than straight-up VNC connection, without having to worry too much about Firewall issues (a big annoyance where I work).
• There's a free 30-day trial

The bad:

• Windows or Mac only, no Linux client :(

The Ugly:

• Beyond the 30 day trial, pricing can be prohibitive depending on your situation.

Answer 5

Perhaps it would be easier to simply grant your reviewer access rights to your VCS repository.

Let them open the file in the web-interface of the VCS and tell you what function/line they're looking at.

I'm with tpdi though; it is helpful to everyone concerned if code carries meaningful comments to begin with.

Answer 6

So ok, I'm doing something like this regularly and based on my experience I think no matter how complex your code is you should go for a two or a step procedure:

Step 1: Let the reviewer look at your code without any explanations and without time pressure. This will provide important written feedback for later use and it will make the walkthrough much easier. Furthermore the reviewer might find some code smells which you would otherwise explain away, prime him, etc.

Step 2: Use skype and teamviewer for going through the code together. Teamviewer is an excellent remote support tool and free for such purposes. I think it's easiest if both persons see the same thing at the same time. Sometimes it can be helpful to step through the logics with the debugger. Take time to make notes and annotations or you will forget half of the remarks.

Answer 7

I continue to go back to VNC for this sort of thing over Goto Meeting etc. It's cheap and easy to set up, and runs a lot of platforms. Since you can both interact with a single desktop it's ideal.

Use VNC, a Notepad session for notes, plus a hands free phone and you're set.

Taking notes that you can both see is important as it makes sure you are on the same page, literally. I prefer to take notes and modify code later, rather than trying to make it a pair programming exercise. If you need that, schedule specific sessions to deal with unresolved issues that may come out of the review.

If you both have second monitors.. maybe consider Etherpad rather than Plain Ol' Notepad. I use this regularly for taking notes during conference calls. Everyone can edit and agree on the notes as you go along.