Does Dictionary.Equals() have an implementation?

Question

Hi all,

I have a Dictionary which I am comparing to another Dictionary (variables typed as IDictionary). Doing d1.Equals(d2) yeilds false. Writing my own code below yields true. Both are System.Collections.Generic.Dictionary. Am I missing something or does Dictionary not have an Equals implementation that compares keys/values?

private static bool DictEquals<K, V>(IDictionary<K, V> d1, IDictionary<K, V> d2)
{
    if (d1.Count != d2.Count)
        return false;

    foreach (KeyValuePair<K, V> pair in d1)
    {
        if (!d2.ContainsKey(pair.Key))
            return false;

        if (!Equals(d2[pair.Key], pair.Value))
            return false;
    }

    return true;
}

Answer 1

Probably the Equals method of the Dictionary class simply resorts to the default implementation inherited from Object, that is, it just compares the Dictionary object reference passed with its own reference. See here: Object.Equals reference

Answer 2

Dictionary.Equals() uses the default Equals from Object, checking if the two objects are the same reference, as does all the other default collections. You're free to create your own subclass with value semantics, though that usually includes things being immutable as well.

Answer 3

Others have mentioned that it is using the Object.Equals implementation, you can use the following to override it:

public class EqualsDictionary<T, T> : Dictionary<T, T>
{
    public override bool Equals(object obj)
    {
        //Place your comparison implementation here
    }
}

Answer 4

Assuming that two dictionaries, one being a SortedList<TKey, TValue> and one a Dictionary<TKey, TValue>, are compared for equality, should it really return true if the items are the same? That would be pretty bad, since they have different characteristics and features (the SortedList<,> for instance allows retrieval via index).

Also, equality and hash code are logically tied together. The hash code should be immutable, otherwise all hash based algorithms will not work. You cannot guarantee this when you're using the contents to check for equality. Therefore, the default implementation (checking if they are the same instance) is quite sane. You're free to create your own content equality comparison though.