tags:

views:

296

answers:

2

Today I was just trying to check how valgrind works. So I created a simple program.

//leak.C
#include<iostream>

class leak
{

   int *p;

   public:

   leak():p(new int[10]()){std::cout<<"Constructor of leak called\n";}
   virtual void set()
   {

       for(int i=0;i<10;++i) p[i]=i*i;
   }

   virtual void display()
   {
       std::cout<<"In leak's display()\n";
       for(int i=0;i<10;++i) std::cout<<p[i]<<std::endl;
   }

   virtual ~leak()
   {
       std::cout<<"Destructor of leak called\n";
       delete[] p;
   }
};

class exleak: public leak
{

     double *r;

     public:

     exleak():r(new double[5]()){std::cout<<"Constructor of exleak called\n";}

     void set()
     {
       leak::set();
       for(int i=0;i<5;i++) r[i]=i*3.0;
     }


     void display()
     {
         leak::display();
         std::cout<<"In exleak's display()\n";
         for(int i=0;i<5;i++)  std::cout<<r[i]<<std::endl;
     }

     ~exleak()
     {

          std::cout<<"Destructor of exleak called\n";
          delete[] r;
     }
};

int main()
{

     leak *x=new exleak();
     x->set();
     x->display();
     delete x;

}

The output was as expected. I expected no memory leak. I compiled the file leak.C and generated an executable leak. But when I entered the following command valgrind --leak-check=yes --verbose ./leak, I was surprised. The code had a memory leak. :-o

This is what I got.

==9320== 
==9320== HEAP SUMMARY:
==9320==     in use at exit: 12 bytes in 1 blocks
==9320==   total heap usage: 3 allocs, 2 frees, 92 bytes allocated
==9320== 
==9320== 12 bytes in 1 blocks are definitely lost in loss record 1 of 1
==9320==    at 0x40263A0: operator new(unsigned int) (vg_replace_malloc.c:214)
==9320==    by 0x8048B0E: main (in /home/prasoon/leak)
==9320== 
==9320== LEAK SUMMARY:
==9320==    definitely lost: 12 bytes in 1 blocks
==9320==    indirectly lost: 0 bytes in 0 blocks
==9320==      possibly lost: 0 bytes in 0 blocks
==9320==    still reachable: 0 bytes in 0 blocks
==9320==         suppressed: 0 bytes in 0 blocks
==9320== 
==9320== For counts of detected and suppressed errors, rerun with: -v
==9320== ERROR SUMMARY: 1 errors from 1 contexts (suppressed: 25 from 6)

How is the code leaking memory?

  definitely lost: 12 bytes in 1 blocks //WHERE?

EDIT : Matter Resolved.

A: 

class exleak has no virtual destructor...

YeenFei
but the base class has...
Yogesh Arora
So, how does it matter here?. Things would have been different had the destructor of `leak` would have not been virtual.
Prasoon Saurav
+2  A: 

I tried it on Linux with 2.6.18-164.11.1.el5 kernel and GCC 4.1.2, it does not give me any leak

and i don't see any issue with the code

Yogesh Arora