How is the value of this variable changing in my C code?

Question

Hi,

I have come across a very odd problem in C that I have never encountered before. I have narrowed it down to the following very simple snippet.

The variables are global and of type:

    int cpd;
    int nPart;

And here is the relevant code snippet which I gradually stripped down to the very minimum needed to produce the issue:

    printf("\ncpd1: %d\n",cpd);

    int p;
    for(p=1;p<=nPart;p++)
    {
        printf("\ncpd2: %d\n",cpd); exit(0);
    }

...The output I get is this:

cpd1: 17

cpd2: 0

How on earth is this possible?! cpd has NOT been reassigned, NO functions have been called... yet it changed? HOW?!?!

This has been driving me slowly insane for quite some time now... ... so any ideas?

thanks for your time, Ben.

EDIT: and when I remove -02 from the makefile arguments to gcc, BOTH the print statements tell me that cpd = 0!

EDIT: Okay, I just found that a variable that is declared globally once, initialised as 4.0, and then never modified is now apparently 1.51086e-311 ... Something is very wrong somewhere...

EDIT: SOLVED!: I had an array of size 1000 that needed to be over 4000, and trying to write to this was corrupting the memory around it. Thing is, this array is NOT accessed anywhere near those print statements, it is accessed in the same function however, much earlier on (large function!). The weird discrepancy between print statements must be some weird artifact of using -O2, as without -O2, both prints of cpd print the corrupted version. Thank you everyone, I wouldnt have worked this out without your help!

Answer 1

An unintialized variable can have any value, typically in debug build it will be set to zero, but you can't rely on this.

Answer 2

That which is posted could not do that. The only explanation is that something else is changing cpd, or cpd has multiple instances.

Answer 3

int main() {
    int cpd = 13;
    int nPart = 17;

    printf("\ncpd1: %d\n",cpd);

    int p;

    for(p=1;p<=nPart;p++) {
            printf("\ncpd2: %d\n",cpd);
    }

    exit(0);
}

This compiles and runs with expected output for me. Have I incorrectly reproduced your example, or is the lack of a closing brace on the end of your for loop (and inclusion of subsequent exit(0) purposeful?

Edit: assume proper includes.

Answer 4

Only possible reason I can think of is that you have another local int cpd variable declared. As an example, I took your code and slightly modified it to add another int cpd declaration and left it uninitialised:
Note I had to set nPart = 1 so the for loop executed at least once

#include <stdio.h>

int cpd;
int nPart = 1;

int main (int argc, char ** argv)
{
 printf("\ncpd1: %d\n",cpd);
 int cpd;


    int p;

    for(p=1;p<=nPart;p++)
    {
        printf("\ncpd2: %d\n",cpd); 
  break;
 }
}

When I ran it, I got the following output:
cpd1: 0

cpd2: 2130567168

As expected, the global variable cpd is 0, the local cpd is uninitialised and can be pretty much any 32 bit value.

Answer 5

If the minimal code snippet you posted does indeed reproduce the problem, then the only explanation here is that your compiler is hopelessly broken and generates meaningless broken code.

However, I strongly suspect that the snippet you posted is not really complete (it is obviously non-compilable) and the problem lies somewhere in the code you omitted.

Answer 6

Stack frame corruption due to buffer overflow is the usual explanation for this. Here's an example:

#include <stdio.h>
#include <string.h>

int main()
{
  int cpd;
  char msg[4];
  cpd = 17;
  printf("%d\n", cpd);
  strcpy(msg, "Oops");
  printf("%d\n", cpd);
  return 0;
}

Output:

17
0

The "msg" string buffer is too short by one character, the string terminator overwrites the value of "cpd".

The best way to find the cause is to use the data breakpoint feature of the debugger. Set a regular breakpoint on the function entry point. Then find the address of the "cpd" variable and a set a byte-size data breakpoint on it. The debugger will stop as soon as the cpd value changes.

Beware that this won't necessarily work in optimized code, the "cpd" value might be stored in a register. Which is another possible explanation why its value is different in separate statements.