views:

102

answers:

3

How to prevent a race condition in MySQL database when two connections want to update the same record?

For example, connection 1 wants to increase "tries" counter. And the second connection wants to do the same. Both connections SELECT the "tries" count, increase the value and both UPDATE "tries" with the increased value. Suddenly "tries" is only "tries+1" instead of being "tries+2", because both connections got the same "tries" and incremented it by one.

How to solve this horrific problem?

Thanks, Boda Cydo.

+3  A: 

Use a single statement instead of two. A single UPDATE statement that performs both the read and the write will be atomic and won't conflict with another simultaneous update.

UPDATE table SET tries = tries + 1 WHERE ...

Or you can use transactions to make the two operations atomic.

BEGIN
SELECT ...
UPDATE ...
COMMIT

Or, more primitively, lock the table while you're reading/writing to it.

LOCK TABLES table WRITE
SELECT ...
UPDATE ...
UNLOCK TABLES
John Kugelman
Yes, but both connections do the same :( Both update `tries = tries + 1` when tries is for example 3. The result is both set it to 4. :(
bodacydo
are you saying you are using this code, and you're seeing this problem? it seems highly unlikly. Please post your code so we can check.
Roland Bouman
No, I am just thinking about what happens if both connections update `tries=tries+1` - they both set it to 4. I have been developing the program alone but when the users start using it, they may get wrong results. :(
bodacydo
A single UPDATE statement will be atomic. You don't have to worry about conflicts if you do the read and update in one statement.
John Kugelman
Thanks for the edit, John. This should solve it. :)
bodacydo
Oh, I didn't know UPDATE was atomic. Whew. I am saved then.
bodacydo
Thanks for helping me out guys!
bodacydo
+3  A: 

Here's 3 different approaches:

Atomic update

update table set tries=tries+1 where condition=value;

and it will be done atomically.

Use transactions

If you do need to first select the value and update it in your application, you likely need to use transactions. That means you'll have to use InnoDB, not MyISAM tables. Your query would be something like:

BEGIN; //or any method in the API you use that starts a transaction
select tries from table where condition=value for update;
.. do application logic to add to `tries`
update table set tries=newvalue where condition=value;
END;

if the transaction fails, you might need to manually retry it.

Version scheme

A common approach is to introduce a version column in your table. Your queries would do something like:

select tries,version from table where condition=value;
.. do application logic, and remember the old version value.
update table set tries=newvalue,version=version + 1 where condition=value and version=oldversion;

If that update fails/returns 0 rows affected, someone else has updated the table in the mean time. You have to start all over - that is, select the new values, do the application logic and try the update again.

nos
Thank you, I didn't know about `for update` construct. I will look into using this piece of code.
bodacydo
A: 

I suggest you to search for topic: "Lock on table" Mysql feature. Locking a table permits to solve this sort of situation

cesko80
Okay. I will also read about this. :)
bodacydo