views:

290

answers:

3

Ok I am checking that a string is at least 4 characters long and 25 or less characters short

I tried to use strlen like this

$userNameSignupLength = strlen($userNameSignup);

else if($userNameSignupLength<4 && $userNameSignupLength>25) {

            $userNameSignupError = "Must be between 4 to 25 characters long";

        }

but it doesn't work... what did I do wrong?

+7  A: 

Using strlen is correct to check the length of a string (in bytes). But a number cannot be both smaller than 4 and greater than 25 at the same time. Use || instead:

if ($userNameSignupLength < 4 || $userNameSignupLength > 25)

Now the condition is fulfilled if the number is either smaller than 4 or greater than 25.

Gumbo
thank you very much lol I do that all the time mess up my ands and ors >< one day I will get it lol ^.^
MrEnder
+2  A: 

Change the && to ||

else if ($userNameSignupLength<4 || $userNameSignupLength>25)
Kevin
+2  A: 

I think you want an OR there:

else if($userNameSignupLength < 4 || $userNameSignupLength > 25) {

Like Gumbo said, the length cannot possibly be both less than 4 AND greater than 25. && means and.

Andy Shellam