views:

71

answers:

1

I have this program, but cin in randomly skips.. I mean sometimes it does, and sometimes it doesn't. Any ideas how to fix this?

    int main(){ 


        /** get course name, number of students, and assignment name **/
        string course_name;
        int numb_students;
        string assignment_name;
        Assignment* assignment;

        cout << "Enter the name of the course" << endl;
        cin >> course_name;

        cout << "Enter the number of students" << endl;
        cin >> numb_students;   

        cout << "Enter the name of the assignment" << endl;
        cin >> assignment_name;

        assignment = new Assignment(assignment_name);

        /** iterate asking for student name and score **/
        int i = 0;
        string student_name;
        double student_score = 0.0;
        while( i < numb_students ){

            cout << "Enter the name for student #" << i << endl;
            cin >> student_name;
            cout << "Enter the score for student #" << i << endl;
            cin >> student_score;
            assignment->addScore( Student( student_name, student_score ));
            i++;
        }
}

OK I figured it out. For anyone that would like to know here's the updated code:

int main(){ 

    /** get course name, number of students, and assignment name **/
    string course_name;
    int numb_students;
    string assignment_name;

    cout << "Enter the name of the course" << endl;
    getline(cin, course_name);

    cout << "Enter the number of students" << endl;
    string temp;
    getline(cin, temp);
    numb_students = atoi(temp.c_str());

    cout << "Enter the name of the assignment" << endl;
    getline(cin, assignment_name);

    Assignment assignment(assignment_name);

    /** iterate asking for student name and score **/
    int i = 0;
    string student_name;
    double student_score = 0.0;
    while( i < numb_students ){

        cout << "Enter the name for student #" << i+1 << endl;
        getline(cin, student_name);     
        cout << "Enter the score for student #" << i+1 << endl;
        getline(cin, temp);
        student_score = atof(temp.c_str());
        assignment.addScore( Student( student_name, student_score ));
        i++;
    }
+5  A: 

I would guess that some of your inputs have spaces in them, which the >> operator treats as the end of a particular input item. The iostreams >> operator is really not designed for interactive input, particularly for strings - you should consider using getline() instead.

Also, you are needlessly using dynamic allocation:

assignment = new Assignment(assignment_name);

would much better be written as:

Assignment assignment(assignment_name);

you should avoid the use of 'new' in your code wherever possible, and instead let the compiler take care of object lifetimes for you.

anon
Yes my input has spaces.... I'll try get line thanks