views:

124

answers:

4

This is really just a "best practices" question...

I find that When developing an app, I often end up with a lot of views.

Is it common practice to break these views up into several view files? In other words... instead of just having views.py, is it common to have views_1.py, views_2.py, views_3.py (but named more appropriately, perhaps by category)?

A: 

As a general guideline, think about readability and maintainability: the default "views.py" is just a suggestion made by initial scaffolding - you do not have to stick to it.

Usually, files with thousands of lines of code are difficult to maintain, for this I usually try to decompose bigger modules into smaller ones.
On the other hand, the division should make sense - splitting related functions into several files, with lots of imports may make maintenance even more difficult.

Finally, you can also think about completely other ways to simplify your application.
Do you see duplicated code? Maybe some functionality could be moved in a completely different application? And so on.

Roberto Liffredo
+4  A: 

Most of your code probably expects your views to be accessible as myapp.views.viewname. One way I've seen people break up their views but keep this python name is to create a views/ directory. views/__init__.py will have:

from foo_views import *
from bar_views import *
from baz_views import *

Then, in views/foo_views.py, put:

def foo_detail(request, ...):
    # your code here

def foo_list(request, ...):
    # your code here

def your_other_view(...):
    # ...

etc. So you move everything from views.py into files in this directory, make __init__.py, delete views.py, and you're done.

Then, when you import myapp.views, myapp.views.foo_detail will refer to the function that you defined in views/foo_views.py.

rescdsk
I like this approach. The only problem is that now I need to put full paths when I import other things from the app. For example, before I could do "from models import *". Now I need to do "from project.app.models import *". Is there any way to fix that?
Brant
You can do relative imports. I've never tried them and they seem a bit tricky, but here's a relevant SO question: http://stackoverflow.com/questions/72852/how-to-do-relative-imports-in-python
rescdsk
A: 

Another option would be to move some of the functionality into one or more apps. This would allow you to move also forms and templates and keeping things structurized. You don't necessarily need to move the models which saves you from model and data migration.

For example you could have the following structure:

main_app/
  |_models.py
  |_views.py
  |_forms.py
  |_urls.py
  |_templates/

sub_app_1/
  |_views.py
  |_forms.py
  |_urls.py
  |_templates/

sub_app_2/
  |_views.py
  |_forms.py
  |_urls.py
  |_templates/
Nathan
A: 

@Brant - Yean, this is actually one of the most practical questions. I today got this problem too when I tried to append another set of views to an existing lengthy views.

@rescdsk - Tried and worked all well ! Thx

Chaobin