views:

915

answers:

3

I am hoping to dynamically update a ModelForm's inline Meta class from my view. Although this code seems to update the exclude list in the Meta class, the output from as_p(), as_ul(), etc does not reflect the updated Meta exclude.

I assume then that the html is generated when the ModelForm is created not when the as_*() is called. Is there a way to force the update of the HTML?

Is this even the best way to do it? I just assumed this should work.

Thoughts?

from django.forms import ModelForm

from testprogram.online_bookings.models import Passenger

class PassengerInfoForm(ModelForm):

    def set_form_excludes(self, exclude_list):
        self.Meta.exclude = excludes_list

    class Meta:
        model = Passenger
        exclude = []
+11  A: 

The Meta class is used to dynamically construct the form definition - so by the time you've created the ModelForm instance, the fields not in the exclude have already been added as the new object's attributes.

The normal way to do it would be to just have multiple class definitions for each possible exclude list. But if you want the form itself to be dynamic, you'll have to create a class definition on the fly. Something like:

def get_form(exclude_list):
    class myform(ModelForm):
        class Meta:
            model = Passenger
            exclude = exclude_list
    return myform

frm_class = get_form( ('field1', 'field2') )
form = frm_class()

UPDATE: I just revisited this post and thought I'd post a little more idiomatic way to handle a dynamic class:

def PassengerForm(exclude_list, *args, **kwargs):
    class MyPassengerForm(ModelForm):
        class Meta:
            model = Passenger
            exclude = exclude_list

        def __init__(self):
            super(MyPassengerForm, self).__init__(*args, **kwargs)

    return MyPassengerForm()

form = PassengerForm( ('field1', 'field2') )
Daniel
+1: dynamic form class construction. Sick.
S.Lott
Excellent. Thanks!
ashchristopher
great example thanks.possible to also have the model set dynamically ? form = getModelForm( Passenger, ('field1', 'field2') )
jujule
jujule: sure, just add a positional argument to the form function: "def PassengerForm(exclude_list, model, *args, **kwargs)", and set the Meta.model field in the same way Meta.exclude is set.
Daniel
+3  A: 

Another way:

class PassengerInfoForm(ModelForm):
    def __init__(self, *args, **kwargs):
        exclude_list = kwargs['exclude_list']
        del kwargs['exclude_list']

        super(PassengerInfoForm, self).__init__(*args, **kwargs)

        for field in exclude_list:
            del self.fields[field]

    class Meta:
        model = Passenger

form = PassengerInfoForm(exclude_list=['field1', 'field2'])
a bit more involved, but will definitely work
Daniel
You should probably use {}.pop() instead of setting it then deleting it.exclude_list = kwargs.pop('exclude_list')Saves a line of code. *shrug*
Justin Lilly
A: 

Similar approach, somewhat different goal (generic ModelForm for arbitrary models):

from django.contrib.admin.widgets import AdminDateWidget
from django.forms import ModelForm
from django.db import models

def ModelFormFactory(some_model, *args, **kwargs):
"""
Create a ModelForm for some_model
"""
widdict = {}
# set some widgets for special fields
for field in some_model._meta.local_fields:
    if type(field) is models.DateField:
        widdict[field.name] = AdminDateWidget()

class MyModelForm(ModelForm): # I use my personal BaseModelForm as parent
    class Meta:
        model = some_model
        widgets = widdict

return MyModelForm(*args, **kwargs)
Hraban