Generating a list of Strings in Obj C

Question

Hi
It seems that Objective C jumps thru hoops to make seemingly simple tasks extremely difficult.

I simply need to create a sequence of strings, image1.jpg, image2.jpg, etc etc

ie in a loop var imgString:String='image'+i+'.jpg;

I assume a best practice is to use a NSMutableString with appendString method?

What am I doing wrong??

NSMutableString *imgString;

    for(int i=1;i<=NUMIMAGES;i++){
    imgString.appendString(@"image"+i+@".jpg");
}

I get the following error

error: request for member 'appendString' in something not a structure or union

Answer 1

I’m not really sure what you’re trying to do, but this might be an inspiration:

NSMutableArray *fileNames = [NSMutableArray array];
for (int i=0; i<max; i++)
    [fileNames addObject:[NSString stringWithFormat:@"image%i.jpg", i]];

As for your error, you’re using the dot syntax where it doesn’t make any sense. Also, you don’t use the + to concatenate strings in Objective-C. The correct appendString syntax looks like this:

NSMutableString *foo = [NSMutableString string];
[foo appendString:@"Hello, "];
[foo appendString:@"world!"];

As you can see on the first line, it is a good idea to initialize objects before you use them :) To concatenate strings you can use the appendString method of NSMutableString or you can create a new immutable string:

NSString *one = @"Hello, ";
NSString *two = [one stringByAppendingString:@"world!"];

If you have more strings to concatenate, you can use the stringWithFormat initializer:

NSString *composed = [NSString stringWithFormat:@"%@, %@ %@!",
     @"Hello", @"Objective-C", @"world"];

If you still have the feeling that Objective-C makes certain things extremely difficult you might gain some advantage by actually learning it ;)

Answer 2

First, your syntax for invoking methods is off - i recommend reading through Apples Introduction to Objective-C. Notably, to invoke a method you use the [someObject someMethod] syntax.

The next problem is that you never create the string you are trying to append to, you can use e.g. [NSMutableString string] for that.

Continuing, to concatenate a mutable string with some formatted string use -appendFormat:, e.g.:

NSMutableString *imgString = [NSMutableString string];

for (int i=1; i<=NUMIMAGES; i++) {
    if (i > 1) [imgString appendString:@", "];
    [imgString appendFormat:@"image%d.jpg", i];
}

Answer 3

Appreciate all the answers!
Sometimes it feels that one needs to be a masochist to be proficient in Objective C!.
Will try the above but ended up using

NSString *string1 = @"image"; 
NSString *string2; 
NSString *string3 = @".jpg"; 
NSString *incString; //*/ 

for(int i=1;i<=NUMIMAGES;i++)
{ 
 incString=[NSString stringWithFormat:@"%d",i]; 
 string2 = [string1 stringByAppendingString:incString]; 
 string3 = [string2 stringByAppendingString:string3]; 
}

Answer 4

I cannot possibly imagine how yielding the string image5image4image3image2image1.jpg in string3 in your "answer" to your own question could be construed as useful or a solution (I pasted your code into an Xcode Foundation tool project w/NUMIMAGES set to 5).

It seems that Objective C jumps thru hoops to make seemingly simple tasks extremely difficult.

Read the Objective-C Guide and the String Programming Guide, then make draw your conclusions. Criticizing something you don't understand is generally counter-productive (we've all done it, though -- easy to do when frustrated).

I simply need to create a sequence of strings, image1.jpg, image2.jpg, etc etc

Naive solution:

#define NUMIMAGES 5
NSMutableArray *fileNames = [NSMutableArray array];
for(int i = 0; i<5; i++)
    [fileNames addObject: [NSString stringWithFormat: @"image%d.jpg", i]];
NSLog(@"fileNames %@", fileNames);

Outputs:

fileNames (
    "image0.jpg",
    "image1.jpg",
    "image2.jpg",
    "image3.jpg",
    "image4.jpg"
)

Note that there isn't anything particularly wrong with the naive solution. It is just more fragile, less efficient, and more code than is necessary.

One Possible Better Solution

1. Add all images into your application project as resources.

2. Use the NSBundle API to grab URLs to all images at once.

I.e.:

NSArray *paths = [[NSBundle mainBundle] pathsForResourcesOfType: @"jpg" inDirectory: nil];

Not only does this remove hardcoding of image names from your code, it also allows the system to optimize directory enumeration and path generation. If you want to load only a subset of images -- say you are writing a game and have a series of images related to monsters -- then put all the related images in a single directory, add the directory to your Resources, then pass that directory's name as the second argument to the above method.

All of this -- and much more -- is documented in the resource programming guide.

Answer 5

The simplest code which does what you want would be something like this:

NSMutableString * string = [NSMutableString string]; for (int i = 1; i <= NUMIMAGES; i++) [string appendFormat: @"image%d.jpg", i];

That's it. As you can see, appendFormat: really makes things a lot easier! But I can't figure out why you would want to do this. You'll get something like:

"image1.jpgimage2.jpgimage3.jpgimage4.jpgimage5.jpg. . ."

What are you actually trying to achieve? Dave