views:

178

answers:

3

I am trying to statically initialize the following structure in Visual Studio 2010:

struct Data
{
   int x;
   union
   {
      const Data* data;
      struct {int x; int y; };
   };
};

The following is fails with error C2440: 'initializing' : cannot convert from 'Data *' to 'char'.

static Data d1;
static Data d = {1, &d1};
static Data d2 = {1, {1, 2}};

I have found references to some ways this can be initialized properly but none of them work in VS2010. Any ideas?

+1  A: 

Change it to:

struct Data
{
   int x;
   union
   {
      const Data* data;
      char ch;
   };
};

static Data d1;
static Data d = {1, &d1};
Paul R
Indeed that works, but I have oversimplified my real-life case so now I have updated the question with a better code which fails for `d2` initialization.
wpfwannabe
I imagine it's not apparent to newcomers why this is supposed to work. I always add a small explanation to my answers of this kind.
Johannes Schaub - litb
+4  A: 

ISO C++03 8.5.1[dcl.init.aggr]/15:

When a union is initialized with a brace-enclosed initializer, the braces shall only contain an initializer for the first member of the union. [Example:

union u { int a; char* b; };
u a = { 1 };
u b = a;
u c = 1; // error
u d = { 0, "asdf" }; // error
u e = { "asdf" }; // error

—end example]

So, generally speaking, it can't be done.

Pavel Minaev
Thanks a lot! I feared that would be the answer. +1 vote for you but answer to `ChrisW` for a usable workaround.
wpfwannabe
+2  A: 

Can you do it by defining overloaded constructors? Untested code ahead:

struct Data 
{ 
    int x; 
    union 
    { 
        const Data* data; 
        struct {int a; int b; } z; 
    } y;

    Data()
    {
        x = 0;
        y.data = 0;
        y.z.a = 0;
        y.z.b = 0;
    }

    Data(int x_, Data* data_)
    {
        x = x_;
        y.data = data_;
    }

    Data(int x_, int a_, int b_)
    {
        x = x_;
        y.z.a = a_;
        y.z.b = b_;
    }
}; 

static Data d1; 
static Data d(1, &d1); 
static Data d2(1, 1, 2); 
ChrisW
Thanks! I made this into a workable solution.
wpfwannabe