views:

131

answers:

2

Related to my other question, please help me debug "An unhandled exception of type 'System.AccessViolationException' occurred in Unknown Module. Additional information: Attempted to read or write protected memory. This is often an indication that other memory is corrupt." Stepping through the code, everything works up until the actual call to del() and fails in that line.

This code is based on this article's sample and this python code which works in python. I can't get the code example as-is to work either (same exception), but I'm hopeful that it's just a little outdated or something.

I understand that the resulting assembly would be theoretically less portable than MSIL can be. Also, I'm not sure what the return type of CPUID1 should be. (4 bytes?)

using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.Reflection;
using System.Runtime.InteropServices;

namespace CPUID
{
    public delegate void CPUID0Delegate(ref byte[] buffer);
    public delegate void CPUID1Delegate(ref byte[] buffer);

    class Program
    {
        static void CPUID0(ref byte[] buffer) { } // Placeholder
        static void CPUID1(ref byte[] buffer) { } // Placeholder

        static void Main(string[] args)
        {
            Console.WriteLine("CPUID0: {0}", string.Join(", ", CPUID0().Select(x => x.ToString("X2")).ToArray()));
            Console.WriteLine("CPUID1: {0}", string.Join(", ", CPUID0().Select(x => x.ToString("X2")).ToArray()));
        }

        unsafe static byte[] CPUID0()
        {
            byte[] buffer = new byte[12];

            // Get the FieldInfo for "_methodPtr"
            Type delType = typeof(Delegate);
            FieldInfo _methodPtr = delType.GetField("_methodPtr", BindingFlags.NonPublic | BindingFlags.Instance);

            if (IntPtr.Size == 4)
            {
                fixed (byte* startAddress = &x86_CPUID0_INSNS[0]) // Take the address of our x86 code
                {
                    CPUID0Delegate del = new CPUID0Delegate(CPUID0);

                    _methodPtr.SetValue(del, (IntPtr)startAddress); // Set our delegate to our x86 code

                    del(ref buffer);
                }
            }
            else if (IntPtr.Size == 8)
            {
                fixed (byte* startAddress = &x64_CPUID0_INSNS[0]) // Take the address of our x64 code
                {
                    CPUID0Delegate del = new CPUID0Delegate(CPUID0);

                    _methodPtr.SetValue(del, (IntPtr)startAddress); // Set our delegate to our x64 code

                    del(ref buffer);
                }
            }

            return buffer;
        }

        unsafe static byte[] CPUID1()
        {
            byte[] buffer = new byte[12];

            // Get the FieldInfo for "_methodPtr"
            Type delType = typeof(Delegate);
            FieldInfo _methodPtr = delType.GetField("_methodPtr", BindingFlags.NonPublic | BindingFlags.Instance);

            if (IntPtr.Size == 4)
            {
                fixed (byte* startAddress = &x86_CPUID1_INSNS[0]) // Take the address of our x86 code
                {
                    CPUID0Delegate del = new CPUID0Delegate(CPUID1);

                    _methodPtr.SetValue(del, (IntPtr)startAddress); // Set our delegate to our x86 code

                    del(ref buffer);
                }
            }
            else if (IntPtr.Size == 8)
            {
                fixed (byte* startAddress = &x64_CPUID1_INSNS[0]) // Take the address of our x64 code
                {
                    CPUID0Delegate del = new CPUID0Delegate(CPUID1);

                    _methodPtr.SetValue(del, (IntPtr)startAddress); // Set our delegate to our x64 code

                    del(ref buffer);
                }
            }

            return buffer;
        }

        #region ASM
        public static byte[] x86_CPUID0_INSNS = new byte[]
        {
            0x53,                   // push   %ebx
            0x31,0xc0,              // xor    %eax,%eax
            0x0f,0xa2,              // cpuid
            0x8b,0x44,0x24,0x08,    // mov    0x8(%esp),%eax
            0x89,0x18,              // mov    %ebx,0x0(%eax)
            0x89,0x50,0x04,         // mov    %edx,0x4(%eax)
            0x89,0x48,0x08,         // mov    %ecx,0x8(%eax)
            0x5b,                   // pop    %ebx
            0xc3                    // ret
        };

        public static byte[] x86_CPUID1_INSNS = new byte[]
        {
            0x53,                   // push   %ebx
            0x31, 0xc0,             // xor    %eax,%eax
            0x40,                   // inc    %eax
            0x0f, 0xa2,             // cpuid
            0x5b,                   // pop    %ebx
            0xc3                    // ret
        };

        public static byte[] x64_CPUID0_INSNS = new byte[]
        {
            0x49, 0x89, 0xd8,       // mov    %rbx,%r8
            0x49, 0x89, 0xc9,       // mov    %rcx,%r9
            0x48, 0x31, 0xc0,       // xor    %rax,%rax
            0x0f, 0xa2,             // cpuid
            0x4c, 0x89, 0xc8,       // mov    %r9,%rax
            0x89, 0x18,             // mov    %ebx,0x0(%rax)
            0x89, 0x50, 0x04,       // mov    %edx,0x4(%rax)
            0x89, 0x48, 0x08,       // mov    %ecx,0x8(%rax)
            0x4c, 0x89, 0xc3,       // mov    %r8,%rbx
            0xc3                    // retq
        };

        public static byte[] x64_CPUID1_INSNS = new byte[]
        {
            0x53,                   // push   %rbx
            0x48,0x31,0xc0,         // xor    %rax,%rax
            0x48,0xff,0xc0,         // inc    %rax
            0x0f,0xa2,              // cpuid
            0x5b,                   // pop    %rbx
            0xc3                    // retq
        }; 
        #endregion
    }
}

Finished working version:

using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.Reflection;
using System.Runtime.InteropServices;

namespace CPUID
{
    [UnmanagedFunctionPointerAttribute(CallingConvention.Cdecl)]
    public unsafe delegate void CPUID0Delegate(byte* buffer);

    [UnmanagedFunctionPointerAttribute(CallingConvention.Cdecl)]
    public unsafe delegate Int32 CPUID1Delegate();

    [Flags()]
    public enum AllocationType : uint
    {
        COMMIT = 0x1000,
        RESERVE = 0x2000,
        RESET = 0x80000,
        LARGE_PAGES = 0x20000000,
        PHYSICAL = 0x400000,
        TOP_DOWN = 0x100000,
        WRITE_WATCH = 0x200000
    }

    [Flags()]
    public enum MemoryProtection : uint
    {
        EXECUTE = 0x10,
        EXECUTE_READ = 0x20,
        EXECUTE_READWRITE = 0x40,
        EXECUTE_WRITECOPY = 0x80,
        NOACCESS = 0x01,
        READONLY = 0x02,
        READWRITE = 0x04,
        WRITECOPY = 0x08,
        GUARD_Modifierflag = 0x100,
        NOCACHE_Modifierflag = 0x200,
        WRITECOMBINE_Modifierflag = 0x400
    }

    class Program
    {
        [DllImport("kernel32.dll", SetLastError = true)]
        static extern IntPtr VirtualAlloc(IntPtr lpAddress, UIntPtr dwSize,
             AllocationType flAllocationType, MemoryProtection flProtect);

        [DllImport("kernel32")]
        private static extern bool VirtualFree(
                IntPtr lpAddress,
                UInt32 dwSize,
                UInt32 dwFreeType);

        static void Main(string[] args)
        {
            Console.WriteLine("CPUID0: {0}", new string(ASCIIEncoding.ASCII.GetChars(CPUID0())));
            Console.WriteLine("CPUID1: {0}", string.Join(", ", CPUID1().Select(x => x.ToString("X2")).ToArray()));
            Console.ReadLine();
        }

        unsafe static byte[] CPUID0()
        {
            byte[] buffer = new byte[12];

            // Get the FieldInfo for "_methodPtr"
            Type delType = typeof(Delegate);
            FieldInfo _methodPtr = delType.GetField("_methodPtr", BindingFlags.NonPublic | BindingFlags.Instance);

            if (IntPtr.Size == 4)
            {
                IntPtr p = VirtualAlloc(IntPtr.Zero, new UIntPtr((uint)x86_CPUID0_INSNS.Length),
                    AllocationType.COMMIT | AllocationType.RESERVE,
                    MemoryProtection.EXECUTE_READWRITE);
                try
                {
                    Marshal.Copy(x86_CPUID0_INSNS, 0, p, x86_CPUID0_INSNS.Length);

                    CPUID0Delegate del = (CPUID0Delegate)Marshal.GetDelegateForFunctionPointer(p, typeof(CPUID0Delegate));

                    fixed (byte* newBuffer = &buffer[0])
                    {
                        del(newBuffer);
                    }
                }
                finally
                {
                    VirtualFree(p, 0, 0x8000);
                }
            }
            else if (IntPtr.Size == 8)
            {
                IntPtr p = VirtualAlloc(IntPtr.Zero, new UIntPtr((uint)x64_CPUID0_INSNS.Length),
                    AllocationType.COMMIT | AllocationType.RESERVE,
                    MemoryProtection.EXECUTE_READWRITE);
                try
                {
                    Marshal.Copy(x64_CPUID0_INSNS, 0, p, x64_CPUID0_INSNS.Length);

                    CPUID0Delegate del = (CPUID0Delegate)Marshal.GetDelegateForFunctionPointer(p, typeof(CPUID0Delegate));

                    fixed (byte* newBuffer = &buffer[0])
                    {
                        del(newBuffer);
                    }
                }
                finally
                {
                    VirtualFree(p, 0, 0x8000);
                }
            }
            else
            {
                throw new NotSupportedException("32 bit and 64 bit only");
            }

            return buffer;
        }

        unsafe static byte[] CPUID1()
        {
            byte[] buffer = new byte[3];
            Int32 result;

            // Get the FieldInfo for "_methodPtr"
            Type delType = typeof(Delegate);
            FieldInfo _methodPtr = delType.GetField("_methodPtr", BindingFlags.NonPublic | BindingFlags.Instance);

            if (IntPtr.Size == 4)
            {
                IntPtr p = VirtualAlloc(IntPtr.Zero, new UIntPtr((uint)x86_CPUID1_INSNS.Length),
                    AllocationType.COMMIT | AllocationType.RESERVE,
                    MemoryProtection.EXECUTE_READWRITE);
                try
                {
                    Marshal.Copy(x86_CPUID1_INSNS, 0, p, x86_CPUID1_INSNS.Length);

                    CPUID1Delegate del = (CPUID1Delegate)Marshal.GetDelegateForFunctionPointer(p, typeof(CPUID1Delegate));

                    result = del();
                }
                finally
                {
                    VirtualFree(p, 0, 0x8000);
                }
            }
            else if (IntPtr.Size == 8)
            {
                IntPtr p = VirtualAlloc(IntPtr.Zero, new UIntPtr((uint)x64_CPUID1_INSNS.Length),
                    AllocationType.COMMIT | AllocationType.RESERVE,
                    MemoryProtection.EXECUTE_READWRITE);
                try
                {
                    Marshal.Copy(x64_CPUID1_INSNS, 0, p, x64_CPUID1_INSNS.Length);

                    CPUID1Delegate del = (CPUID1Delegate)Marshal.GetDelegateForFunctionPointer(p, typeof(CPUID1Delegate));

                    result = del();
                }
                finally
                {
                    VirtualFree(p, 0, 0x8000);
                }
            }
            else
            {
                throw new NotSupportedException("32 bit and 64 bit only");
            }

            return BitConverter.GetBytes(result).Take(3).Reverse().ToArray();
        }

        #region ASM
        public static byte[] x86_CPUID0_INSNS = new byte[]
        {
            0x53,                   // push   %ebx
            0x31,0xc0,              // xor    %eax,%eax
            0x0f,0xa2,              // cpuid
            0x8b,0x44,0x24,0x08,    // mov    0x8(%esp),%eax
            0x89,0x18,              // mov    %ebx,0x0(%eax)
            0x89,0x50,0x04,         // mov    %edx,0x4(%eax)
            0x89,0x48,0x08,         // mov    %ecx,0x8(%eax)
            0x5b,                   // pop    %ebx
            0xc3                    // ret
        };

        public static byte[] x86_CPUID1_INSNS = new byte[]
        {
            0x53,                   // push   %ebx
            0x31, 0xc0,             // xor    %eax,%eax
            0x40,                   // inc    %eax
            0x0f, 0xa2,             // cpuid
            0x5b,                   // pop    %ebx
            0xc3                    // ret
        };

        public static byte[] x64_CPUID0_INSNS = new byte[]
        {
            0x49, 0x89, 0xd8,       // mov    %rbx,%r8
            0x49, 0x89, 0xc9,       // mov    %rcx,%r9
            0x48, 0x31, 0xc0,       // xor    %rax,%rax
            0x0f, 0xa2,             // cpuid
            0x4c, 0x89, 0xc8,       // mov    %r9,%rax
            0x89, 0x18,             // mov    %ebx,0x0(%rax)
            0x89, 0x50, 0x04,       // mov    %edx,0x4(%rax)
            0x89, 0x48, 0x08,       // mov    %ecx,0x8(%rax)
            0x4c, 0x89, 0xc3,       // mov    %r8,%rbx
            0xc3                    // retq
        };

        public static byte[] x64_CPUID1_INSNS = new byte[]
        {
            0x53,                   // push   %rbx
            0x48,0x31,0xc0,         // xor    %rax,%rax
            0x48,0xff,0xc0,         // inc    %rax
            0x0f,0xa2,              // cpuid
            0x5b,                   // pop    %rbx
            0xc3                    // retq
        };
        #endregion
    }
}
+2  A: 

I'm fairly certain you're being blocked by DEP. The x_CPUIDy_INSNS byte arrays are in a segment of memory marked as data and non-executable.

EDIT:

That being said, I've gotten a version that compiles and runs, but I don't think gets the right values. Perhaps this will get you along your way.

EDIT 2:

I think I have the right values coming back now. Feel free to validate.

namespace CPUID
{
    using System;
    using System.Globalization;
    using System.Linq;
    using System.Reflection;
    using System.Runtime.InteropServices;
    using System.Text;

    internal static class Program
    {
        [Flags]
        private enum AllocationTypes : uint
        {
            Commit = 0x1000,
            Reserve = 0x2000,
            Reset = 0x80000,
            LargePages = 0x20000000,
            Physical = 0x400000,
            TopDown = 0x100000,
            WriteWatch = 0x200000
        }

        [Flags]
        private enum MemoryProtections : uint
        {
            Execute = 0x10,
            ExecuteRead = 0x20,
            ExecuteReadWrite = 0x40,
            ExecuteWriteCopy = 0x80,
            NoAccess = 0x01,
            ReadOnly = 0x02,
            ReadWrite = 0x04,
            WriteCopy = 0x08,
            GuartModifierflag = 0x100,
            NoCacheModifierflag = 0x200,
            WriteCombineModifierflag = 0x400
        }

        [Flags]
        private enum FreeTypes : uint
        {
            Decommit = 0x4000,
            Release = 0x8000
        }

        [UnmanagedFunctionPointerAttribute(CallingConvention.Cdecl)]
         private unsafe delegate void CPUID0Delegate(byte* buffer);

        [UnmanagedFunctionPointerAttribute(CallingConvention.Cdecl)]
        private unsafe delegate void CPUID1Delegate(byte* buffer);

        private static void Main()
        {
            Console.WriteLine("CPUID0: {0}", string.Join(", ", CPUID0().Select(x => x.ToString("X2", CultureInfo.InvariantCulture))));
            Console.WriteLine("CPUID0: {0}", new string(ASCIIEncoding.ASCII.GetChars(CPUID0())));
            Console.WriteLine("CPUID1: {0}", string.Join(", ", CPUID1().Select(x => x.ToString("X2", CultureInfo.InvariantCulture))));
            Console.ReadLine();
        }

        private static unsafe byte[] CPUID0()
        {
            byte[] buffer = new byte[12];

            if (IntPtr.Size == 4)
            {
                IntPtr p = NativeMethods.VirtualAlloc(
                    IntPtr.Zero,
                    new UIntPtr((uint)x86_CPUID0_INSNS.Length),
                    AllocationTypes.Commit | AllocationTypes.Reserve,
                    MemoryProtections.ExecuteReadWrite);
                try
                {
                    Marshal.Copy(x86_CPUID0_INSNS, 0, p, x86_CPUID0_INSNS.Length);

                    CPUID0Delegate del = (CPUID0Delegate)Marshal.GetDelegateForFunctionPointer(p, typeof(CPUID0Delegate));

                    fixed (byte* newBuffer = &buffer[0])
                    {
                        del(newBuffer);
                    }
                }
                finally
                {
                    NativeMethods.VirtualFree(p, 0, FreeTypes.Release);
                }
            }
            else if (IntPtr.Size == 8)
            {
                IntPtr p = NativeMethods.VirtualAlloc(
                    IntPtr.Zero,
                    new UIntPtr((uint)x64_CPUID0_INSNS.Length),
                    AllocationTypes.Commit | AllocationTypes.Reserve,
                    MemoryProtections.ExecuteReadWrite);
                try
                {
                    Marshal.Copy(x64_CPUID0_INSNS, 0, p, x64_CPUID0_INSNS.Length);

                    CPUID0Delegate del = (CPUID0Delegate)Marshal.GetDelegateForFunctionPointer(p, typeof(CPUID0Delegate));

                    fixed (byte* newBuffer = &buffer[0])
                    {
                        del(newBuffer);
                    }
                }
                finally
                {
                    NativeMethods.VirtualFree(p, 0, FreeTypes.Release);
                }
            }

            return buffer;
        }

        private static unsafe byte[] CPUID1()
        {
            byte[] buffer = new byte[12];

            if (IntPtr.Size == 4)
            {
                IntPtr p = NativeMethods.VirtualAlloc(
                    IntPtr.Zero,
                    new UIntPtr((uint)x86_CPUID1_INSNS.Length),
                    AllocationTypes.Commit | AllocationTypes.Reserve,
                    MemoryProtections.ExecuteReadWrite);
                try
                {
                    Marshal.Copy(x86_CPUID1_INSNS, 0, p, x86_CPUID1_INSNS.Length);

                    CPUID1Delegate del = (CPUID1Delegate)Marshal.GetDelegateForFunctionPointer(p, typeof(CPUID1Delegate));

                    fixed (byte* newBuffer = &buffer[0])
                    {
                        del(newBuffer);
                    }
                }
                finally
                {
                    NativeMethods.VirtualFree(p, 0, FreeTypes.Release);
                }
            }
            else if (IntPtr.Size == 8)
            {
                IntPtr p = NativeMethods.VirtualAlloc(
                    IntPtr.Zero,
                    new UIntPtr((uint)x64_CPUID1_INSNS.Length),
                    AllocationTypes.Commit | AllocationTypes.Reserve,
                    MemoryProtections.ExecuteReadWrite);
                try
                {
                    Marshal.Copy(x64_CPUID1_INSNS, 0, p, x64_CPUID1_INSNS.Length);

                    CPUID1Delegate del = (CPUID1Delegate)Marshal.GetDelegateForFunctionPointer(p, typeof(CPUID1Delegate));

                    fixed (byte* newBuffer = &buffer[0])
                    {
                        del(newBuffer);
                    }
                }
                finally
                {
                    NativeMethods.VirtualFree(p, 0, FreeTypes.Release);
                }
            }

            return buffer;
        }

        private static class NativeMethods
        {
            [DllImport("kernel32.dll", SetLastError = true)]
            internal static extern IntPtr VirtualAlloc(
                IntPtr lpAddress,
                UIntPtr dwSize,
                AllocationTypes flAllocationType,
                MemoryProtections flProtect);

            [DllImport("kernel32")]
            [return: MarshalAs(UnmanagedType.Bool)]
            internal static extern bool VirtualFree(
                IntPtr lpAddress,
                uint dwSize,
                FreeTypes flFreeType);
        }

        #region ASM
        private static byte[] x86_CPUID0_INSNS = new byte[]
            {
                0x53,                      // push   %ebx
                0x31, 0xc0,                // xor    %eax,%eax
                0x0f, 0xa2,                // cpuid
                0x8b, 0x44, 0x24, 0x08,    // mov    0x8(%esp),%eax
                0x89, 0x18,                // mov    %ebx,0x0(%eax)
                0x89, 0x50, 0x04,          // mov    %edx,0x4(%eax)
                0x89, 0x48, 0x08,          // mov    %ecx,0x8(%eax)
                0x5b,                      // pop    %ebx
                0xc3                       // ret
            };

        private static byte[] x86_CPUID1_INSNS = new byte[]
            {
                0x53,                   // push   %ebx
                0x31, 0xc0,             // xor    %eax,%eax
                0x40,                   // inc    %eax
                0x0f, 0xa2,             // cpuid
                0x5b,                   // pop    %ebx
                0xc3                    // ret
            };

        private static byte[] x64_CPUID0_INSNS = new byte[]
            {
                0x49, 0x89, 0xd8,       // mov    %rbx,%r8
                0x49, 0x89, 0xc9,       // mov    %rcx,%r9
                0x48, 0x31, 0xc0,       // xor    %rax,%rax
                0x0f, 0xa2,             // cpuid
                0x4c, 0x89, 0xc8,       // mov    %r9,%rax
                0x89, 0x18,             // mov    %ebx,0x0(%rax)
                0x89, 0x50, 0x04,       // mov    %edx,0x4(%rax)
                0x89, 0x48, 0x08,       // mov    %ecx,0x8(%rax)
                0x4c, 0x89, 0xc3,       // mov    %r8,%rbx
                0xc3                    // retq
            };

        private static byte[] x64_CPUID1_INSNS = new byte[]
            {
                0x53,                     // push   %rbx
                0x48, 0x31, 0xc0,         // xor    %rax,%rax
                0x48, 0xff, 0xc0,         // inc    %rax
                0x0f, 0xa2,               // cpuid
                0x5b,                     // pop    %rbx
                0xc3                      // retq
            };
        #endregion
    }
}
Jesse C. Slicer
Wouldn't that block the python script too? It seems to use a similar mechanism.
uosɐſ
More than likely, yes. You can try excluding the python interpreter in Data Execution Prevention tab of the Performance Options dialog (accessible from the Advanced tab of the System Properties applet) and seeing if that works. You have to a lot of chicanery to get around it for .NET apps though.
Jesse C. Slicer
I've added some code which, at the very least, doesn't crash. Doesn't seem to get the right values though, but I hope it starts you off in the right direction.
Jesse C. Slicer
Yes, I get all zeros. But I like your changes. Effectively copies it into an executable segment, right?
uosɐſ
I've just made more changes. Yes, copies it into an executable segment. The "more changes" are a cleaner way to create a delegate to a memory pointer and passing the pointer to the buffer correctly.
Jesse C. Slicer
Yes, `Console.WriteLine("CPUID0: {0}", new string(ASCIIEncoding.ASCII.GetChars(CPUID0())));` gives "GenuineIntel" as expected. Still getting zeros for CPUID1. Not sure what it's supposed to do...
uosɐſ
anybody what to expect as the result for CPUID1?
uosɐſ
From [Wikipedia](http://en.wikipedia.org/wiki/CPUID) it seems that CPUID should fill 3 relevant bytes of data - I thought three in the first place but I was afraid to say it because 3 was a silly number, I thought. So, OK, but we're still getting all zeros and I don't think this is correct. Maybe it is?
uosɐſ
Got it! Thanks for your help
uosɐſ
+1  A: 

Can I suggest the following page: http://devpinoy.org/blogs/cvega/archive/2006/04/07/2658.aspx

This page will show you the assembly source code for CPUID, how to compile it into a DLL and how to call it from C#.

Also if you need other hardware identification procedures, may I suggest this page: http://www.codeproject.com/KB/system/GetHardwareInformation.aspx

This page shows how to get information like motherboard info, hard drive info, cpu info, video card info, etc etc.

icemanind