tags:

views:

2413

answers:

3

I'm trying to extend some "base" classes in Python:

class xlist (list):
    def len(self):
        return len(self)

    def add(self, *args):
        self.extend(args)
        return None


class xint (int):
    def add(self, value):
        self += value
        return self


x = xlist([1,2,3])
print x.len()   ## >>> 3 ok
print x         ## >>> [1,2,3] ok
x.add (4, 5, 6)
print x         ## >>> [1,2,3,4,5,6] ok

x = xint(10)
print x         ## >>> 10 ok
x.add (2)
print x         ## >>> 10  # Not ok (#1)

print type(x)         ## >>> <class '__main__.xint'> ok
x += 5
print type(x)         ## >>> <type 'int'>  # Not ok (#2)

It works fine in the list case because the append method modifies the object "in place", without returning it. But in the int case, the add method doesn't modify the value of the external x variable. I suppose that's fine in the sense that self is a local variable in the add method of the class, but this is preventing me from modifying the initial value assigned to the instance of the class.

Is it possible to extend a class this way or should I define a class property with the base type and map all the needed methods to this property?

A: 

Ints are immutable and you can't modify them in place, so you should go with option #2 (because option #1 is impossible without some trickery).

dwestbrook
+4  A: 

int is a value type, so each time you do an assignment, (e.g. both instances of += above), it doesn't modify the object you have on the heap, but replaces the reference with one of the result of the right hand side of the assignment (i.e. an int)

list isn't a value type, so it isn't bound by the same rules.

this page has more details on the differences: http://docs.python.org/ref/objects.html

IMO, yes, you should define a new class that keeps an int as an instance variable

John Douthat
Python does not have "value types" and reference types. The distinction between mutable and immutable types is only somewhat similar and isn't based on that sort of distinction. Your recommendation to use composition instead of inheritance is great, though.
Mike Graham
+8  A: 

Your two xint examples don't work for two different reasons.

The first doesn't work because self += value is equivalent to self = self + value which just reassigns the local variable self to a different object (an integer) but doesn't change the original object. You can't really get this

>>> x = xint(10)
>>> x.add(2)

to work with a subclass of int since integers are immutable.

To get the second one to work you can define an __add__ method, like so:

class xint(int):
    def __add__(self, value):
        return xint(int.__add__(self, value))

>>> x = xint(10)
>>> type(x)
<class '__main__.xint'>
>>> x += 3
>>> x
13
>>> type(x)
<class '__main__.xint'>
dF