views:

120

answers:

4

Ok people, despite the best-known-practices, today I decided to do this:

<img src='<? include("dir/dir/img.png"); ?>'>

With 6 diferent .png images.

Sadly, only 2 of the 6 were nicely visible on the browser.

Why only 2 of the 6 images were shown? Maybe there were data losses bits on the way?

Thank you for your time :]

+5  A: 

That was not supposed to work at all.

For a standard way to do that (including images inline in the HTML document instead of pointing to their URL), see the data URI scheme.

Artefacto
Darn, ran out of votes for today. I think you should mention using `file_get_contents` to read a file instead of calling `include`. (`include`d data is a security risk!)
strager
You're right. If he controls the images, it's not necessarily a security risk, but the image may contain, by chance, the characters `<?`. Not to mention, it will output immediately, so he cannot manipulate the data to build the data URI.
Artefacto
You *could* have some output buffering kung-fu...
strager
A: 

include() tells PHP to parse that file. If, by any chance, it contains <?, you’ll be in real trouble. Instead, use readfile().

Additionally, Artefacto’s answer has to be considered as well.

Scytale
Yes, xD I was thinking about it in my way home.
sadasant
+7  A: 

It does not work because src attribute of an <img> tag is not supposed to contain the raw data of an image; rather, it is supposed to contain a URI that points to the image data.

By using data: URIs, you can embed the image directly in your (X)HTML document. Note that this will not work in many browsers such as older versions of Internet Explorer. As well, there are limits, such as the 32KB limit IE8 places on data: URIs.

Using PHP, here's what your code would look like:

<img src='data:image/png;base64,<?php echo base64_encode(file_get_contents("dir/dir/img.png")); ?>'>

Don't forget to change the image/png part of the URL if the type of image that you are using changes. For example, if you use a GIF image, change it to image/gif.

Dumb Guy
+1 good snippet
Matt Williamson
The weird fact is that it worked 2 times XD!!! but, alright, you just gave the right way. Thank you :]
sadasant
+1  A: 
< img src='< ?php echo 'data:image/png;base64,' . base64_encode(file_get_contents('dir/dir/img.png')) ; ?> ' >
judge