views:

49

answers:

3

I've been trying to make a dict subclass inheriting from UserDict.DictMixin that supports non-hashable keys. Performance isn't a concern. Unfortunately, Python implements some of the functions in DictMixin by trying to create a dict object from the subclass. I can implement these myself, but I am stuck on cmp

I cannot find a succinct description of the logic used by the built-in cmp for the dict class.

A: 

There is a description of __cmp__ here, but I think the important thing to note is that __cmp__ is only used if the “rich comparison” methods, such as __lt__ and __eq__ are not defined. Moreover, in Python3, __cmp__ is removed from the language. So perhaps eschew __cmp__ altogether and just define __lt__ and __eq__.

unutbu
Yeah, I'm just trying to make the interface match 2.4 dict's (work requirement). I'll probably do a full on 3.x port of this code later.
DannoHung
+1  A: 

An alternative is to use the Mapping ABC from the collections package. It is available in 2.6 and up. You just inherit from collections.Mapping and implement the __getitem__, __contains__, and __iter__ methods. You get everything else for free.

Eric Snow
+1  A: 

If you are asking how comparing dictionaries works, it is this:

To compare dicts A and B, first compare their lengths. If they are unequal, then return cmp(len(A), len(B). Next, find the key adiff in A that is the smallest key for which A[adiff] != B[adiff]. Also find the smallest key bdiff in B for which A[bdiff] != B[bdiff]. If adiff != bdiff, then return cmp(adiff, bdiff). Else return cmp(A[adiff], B[bdiff]).

In pseudo-code:

def smallest_diff_key(A, B):
    """return the smallest key adiff in A such that A[adiff] != B[bdiff]"""
    diff_keys = [k for k in A if A.get(k) != B.get(k)]
    return min(diff_keys)

def dict_cmp(A, B):
    if len(A) != len(B):
        return cmp(len(A), len(B))
    adiff = smallest_diff_key(A, B)
    bdiff = smallest_diff_key(B, A)
    if adiff != bdiff:
        return cmp(adiff, bdiff)
    return cmp(A[adiff], b[bdiff])

This is translated from the 2.6.3 implementation in dictobject.c.

Ned Batchelder
Thank you kindly!
DannoHung
@Ned: Did you know that by reading the source for `dict_compare` (http://svn.python.org/projects/python/trunk/Objects/dictobject.c) or is it documented somewhere?
unutbu
I read the source.
Ned Batchelder
@Ned: Thanks for the info. (PS. I guess this means the behavior of `dict.__cmp__` may vary across implementations. :-/ )
unutbu