ansaurus

Question

perl - help with hash and dumping of records

Answer 1

A:

What do you expect $ARGV to be?

reinierpost 2010-08-20 22:01:53

$ARGV is a logfile. i'm looping more than 1 logfile in from other servers. I am just testing now one just one logfile and there are a number of entries there that I am missing. I am basically seeing the last set of data towards the end of the log..

jda6one9 2010-08-20 22:08:25

Questions for clarification go into the comment box, not in the answer box.

daxim 2010-08-22 09:32:04

The point is that both the foreach loop and $ServerName variable and the while(<>) and $ARGV both loop over the values in @ARGV - you want a single loop there.

reinierpost 2010-08-23 10:32:33

Answer 2

+2 A:

Based on the debug output, it looks like your problem is here:

if ($line =~ m/(ERROR)[:=](.+)/){
    my $BckupKey="8-Status";
    my $BckupVal="Unsuccessful";
    $MyItems{$ServerName}{$BckupSet}->{$BckupKey} = $BckupVal;
    print "$BckupKey=$BckupVal\n" if debug;
}

To save all errors, you'll need to treat that hash slot as a reference to an array:

if ($line =~ m/(ERROR)[:=](.+)/){
    my $BckupKey="8-Status";
    my $BckupVal="Unsuccessful";
    push @{ $MyItems{$ServerName}{$BckupSet}{$BckupKey} } => $BckupVal;
    print "$BckupKey=$BckupVal\n" if debug;
}

In your dump, the 8-Status values will resemble

'8-Status' => [ 'Unsuccessful', 'Other error', 'Et cetera' ],

If you want to loop over them later, you'd do something like

foreach my $err (@{ $MyItems{$ServerName}{$BckupSet}{$BckupKey} }) {
    print "got $err\n";
}

To get only the first, you'd write

print $MyItems{$ServerName}{$BckupSet}{$BckupKey}[0], "\n";

Another issue is

foreach my $ServerName(@ARGV){
   while (my $line = <>){

Realize that while (<>) { ... } implicitly loops over all files named in @ARGV, so nesting it inside a loop over @ARGV doesn't quite make sense. If your command line is of the form

$ readlogs server1 server2 server3 log1 log2

then you'd want to first remove from @ARGV the servers using shift. Distinguishing arguments the user intends as server hostnames could be tricky. One convention is using -- to signal the end of option processing, so you might

my @servers;
while (@ARGV) {
  my $server = shift;
  last if $server eq "--"
  push @servers => $server;
}

die "Usage: $0 server .. -- log ..\n" unless @ARGV;

while (<>) {
  # ...
}

Greg Bacon 2010-08-20 22:06:27

@gbacon - thank you. would i apply the push to all my other if conditions as well? printing the keys too?

jda6one9 2010-08-20 22:27:15

@jda6one9 Using `push` for all of them would work, but you may get annoyed with one-element arrays. Doing it this way has the advantage of never throwing away data, but it may be too permissive for what you want to do.

Greg Bacon 2010-08-20 22:53:22

@gbacon - you helped me earlier with using this --> xargs -I{} ./myscript.pl {} <prodlogs.txt Where 'prodlogs.txt' is a list of all there server logs I need to scan. Anyways, i will definitely take note of your input. thanks again.

jda6one9 2010-08-20 23:14:01

@jda6one9 You're welcome. I'm glad it helps.

Greg Bacon 2010-08-20 23:50:18

Answer 3

+2 A:

This is off topic, but any time you need deeply nested data structures your code runs a risk of becoming bloated and hard to read. Simple convenience variables go a long way toward streamlining things and relieving the reader of the code (you, 3 months from now) of having to perform many mental diffs:

# A convenience var.
my $bs = $MyItems{$ServerName}{$BckupSet};

# The rest of your code can use the var.
$bs->{'1-Server'} = $ServerName;

Also, you've got several if blocks that do basically the same thing. Seems amenable to some sort of dispatch table strategy:

my @dispatch_table = (
    {
        regex => qr/(backup-date)[:=](.+)/,
        key   => '4-DateStamp',
        val   => sub { $2 },
    },
    {
        # etc.
    },
);

Then your if blocks boil down to something like this:

for my $dt (@dispatch_table){
    next unless $line =~ $dt->{regex};
    $bs->{ $dt->{key} } = $dt->{val}->();
}

FM 2010-08-21 00:13:11

@FM - thanks for the tips! I've basically learned perl in the last few weeks. So, I'll take what I can get as far as learning.

jda6one9 2010-08-21 03:44:05

ansaurus

tags:

views:

answers:

perl - help with hash and dumping of records

related questions