c++ 3d arrays

Question

I'm trying to run a 3d array but the code just crashes in windows when i run it, here's my code;

#include <iostream>

using namespace std;

int main(){

    int myArray[10][10][10];

    for (int i = 0; i <= 9; ++i){
     for (int t = 0; t <=9; ++t){            
            for (int x = 0; x <= 9; ++t){

          myArray[i][t][x] = i+t+x; 

            }

        }

     }


    for (int i = 0; i <= 9; ++i){
     for (int t = 0; t <=9; ++t){
            for (int x = 0; x <= 9; ++t){

          cout << myArray[i][t][x] << endl;

            }

        }

    }

    system("pause");

}

can someone throw me a quick fix / explanation

Answer 1

You twice have the line

for (int x = 0; x <= 9; ++t){

when you mean

for (int x = 0; x <= 9; ++x){

Classic copy-and-paste error.

BTW, if you run this in a debugger and look at the values of the variables, it's pretty easy to see what's going on.

Answer 2

David's answer is correct.

Incidentally, convention is to use i,j,and k for nested iterator indices, and also to use < array_length rather than <= array_length -1 as the terminator.

If you do that, then you can make the array size a constant and get rid of some magic numbers.

Also, an assertion at the point where you use the array indices might have pointed you to the error.

The result may look like:

const std::size_t ARRAY_SIZE = 10;

int myArray[ARRAY_SIZE][ARRAY_SIZE][ARRAY_SIZE];

for (std::size_t i = 0; i < ARRAY_SIZE; ++i) 
{
    for (std::size_t j = 0; j < ARRAY_SIZE; ++j)
    {
        for (std::size_t k = 0; k < ARRAY_SIZE; ++k)
        {
            std::assert (i < ARRAY_SIZE && j < ARRAY_SIZE && k < ARRAY_SIZE);
            // Do stuff
        }
    }
}