tags:

views:

171

answers:

6
// ExampleCodes.cpp : Defines the entry point for the console application.
//

#include "stdafx.h"
#include<stdio.h>
#include<iostream>
using namespace std;    

char* stringReverse(char* s)    
{    

    char temp, *p,*q;    
    q = s;    
    while( *(++q));    
    for( p = s; p &lt; --q; p++)    
    {    
        temp = *p;    
        *p = *q;     
        *q = temp;    
    }    
    return s;    
}    


int _tmain(int argc, _TCHAR* argv[])    
{    

    stringReverse("StringReverse");    
    return 0;    
}    
+8  A: 

You can't modify constant string literals.

stringReverse("StringReverse");

You could use a character array instead:

char str[] = "StringReverse";
Mark Byers
A: 

You never allocated any memory for p. You can try p = new char[sizeof(s)];

Alexander Rafferty
`p` doesn't need its own memory - the function reverses a string in-place.
caf
Okay, my mistake. His function doesn't seem to make much sense to me. I think that it could be changed to be make more clear.
Alexander Rafferty
+5  A: 

String literals, like "StringReverse", are not allowed to be modified in C. Use an array:

char str[] = "StringReverse";
stringReverse(str);

Note that your stringReverse() function has undefined behaviour if you feed it a zero-length string.

caf
A: 

Perhaps you should write something like this:

// in - string to reverse
// out - buffer for reversed string
// l - size of in

StringReverse(char* in, char* out, int l) {
  for (int i=0;i<l;i++) {
    out[l-(i+1)] = in[i];
  }
}

*There is very very little to no speed difference between [] and *(p++) / *(p--)

Alexander Rafferty
A: 

Well I was going to clean up the awful source in the OP but instead I'll just post a cleaner version:

#include <stdio.h>
#include <string.h>

void reverse_string(char *s)
{
    char *q = s + strlen(s);
    for (char *p = s; p < --q; p++)
    {
        char temp = *p;
        *p = *q;
        *q = temp;
    }
}

int main()
{
    char s[] = "StringReverse";
    reverse_string(s);
    puts(s);
    return 0;
}

I hope for your sake Amit that you're still a student.

Update0

This is actually pure C, so learn from and awe at its performance but don't start writing C++ like this.

Matt Joiner
I'm half tempted to downvote for "cleaning up" code, and then adding an xor hack.
Dennis Zickefoose
I'm half-tempted to downvote just for the xor hack. Unless you've got a benchmark showing that xor is universally faster than using a temporary, don't bother with it.
greyfade
The xor stuff was just for kicks, I'll remove it.
Matt Joiner
@Matt: Still, this is a C++ question. What's with `std::swap(*p,*q)`? And in C++, those headers should be `<cstdio>` and `<cstring>`, and it's `std::strlen()`.
sbi
@sbi: Yeah that's true. Suddenly I don't feel like doing C++ (that was quick, I hadn't started yet) ;]
Matt Joiner
A: 

Thanks you guys for posting your answers! I somewhat agree with Matt Joiner- Thanks Matt for your comment, But I didn't want to use any library function like strlen(s). Cheers Amit