views:

93

answers:

2

In my web app, I use Ctrl + Arrow keys to navigate from cell to cell in a table.

All cells contain a visible <span>, and a hidden <input> element -- their values are kept in sync.

When a cell is activated, the <span> is hidden, while the input is shown.

Everything works just fine in Firefox, IE, Opera, etc. Yet, when I load up Chrome, using Ctrl+Left or Ctrl+Right crashes the page (I'm seeing the "Aw Snap" page). Odd thing is, Ctrl+Up and Ctrl+Down work.

I've identified that the following code is (directly or indirectly responsible for the crashes):

/**
 * Deactivates a cell, hiding its input field, and showing its span field
 */
View.prototype.deactivateCell = function (cell){
 //Show the span, hide the input
 var label = cell.descendants()[0];
 var input = cell.descendants()[1];
 if(label){
  label.show();
 }
 if(input){
  //THIS NEXT LINE IN PARTICULAR CAUSES THE CRASH
  //I've also tried input.style.display = "none"; - same result
  input.hide();
 }
}

Odd thing is, this code is called by Ctrl+Up/Down, as well as Ctrl+Left/Right - yet it only crashes on Left/Right -- even with identical cell values!

All of these cells have two, and only two, descendants... And the crash has nothing to do with the source cells, or the destination cells -- it's possible to move into any cell from above, but not from the left.

What's even stranger; adding an alert(1); at the end of the deactivateCell(cell) method prevents the crash. Putting it at the start of the method has no effect (Other then displaying the alert dialogue, before the crash)

I've tried isolating the relevant HTML + this method in a test file - I could not reproduce the crash.

Has anyone encountered this? Should I write it off as a browser bug? Does anyone know how I might debug this, or try to fix it? I haven't the foggiest impression how my Javascript can cause the browser to caput, when so many other websites are fine.

+1  A: 

I'm not a prototype hero, but I noticed that you call cell.descendants() without checking if cell is null or not.

Also, are you hiding the current input the cursor is in? if so, try to focus() to a different input before you hide the current one.

Nir Levy
`cell` is tested to be not null in the calling method, but thanks - that is a good practice. I've also tried shifting focus - to no avail.
Vladislav
A: 

It turns out this is a bug with Webkit that was already filed and fixed.

Vladislav