views:

47

answers:

1

I'm trying to do some "complex" math where I need to call upon some of JavaScript's Math properties to solve the quadratic equation. Does the following method work?

    root = Math.pow(inputb,2) - 4 * inputa * inputc;
    root1 = (-inputb + Math.sqrt(root))/2*inputa;
    root2 = (-inputb - Math.sqrt(root))/2*inputa;

Does this look correct?

For some reason, I'm not seeing correct results..

inputa, inputb, and inputc are all variables which store user-input from a text field by the way.

FULL CODE

<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<title>Quadratic Root Finder</title>

<script src="http://ajax.googleapis.com/ajax/libs/jquery/1.4.2/jquery.min.js"&gt;&lt;/script&gt;

<script>
window.onload = function() {



    $('.error').hide();



    document.getElementById('quadraticcalculate').onclick = function calculateQuad()
    {
        var inputa = document.getElementById('variablea').value;
        var inputb = document.getElementById('variableb').value;
        var inputc = document.getElementById('variablec').value;

        inputa = new Number(inputa); // try to convert to number
        if (isNaN(inputa)) { // use built in method to check for NaN
            $('#quadraticaerror').show();
            return;
        }

        inputb = new Number(inputb); // try to convert to number
        if (isNaN(inputb)) { // use built in method to check for NaN
            $('#quadraticberror').show();
            return;
        }

        inputc = new Number(inputc); // try to convert to number
        if (isNaN(inputc)) { // use built in method to check for NaN
            $('#quadraticcerror').show();
            return;
        }

        root = Math.pow(inputb,2) - 4 * inputa * inputc;
        root1 = (-inputb + Math.sqrt(root))/(2*inputa);
        root2 = (-inputb - Math.sqrt(root))/(2*inputa);

        document.getElementById('root1').value = root1;
        document.getElementById('root2').value = root2;
        if(root<'0')
        {
            document.getElementById('root1').value = 'No real solution'
            document.getElementById('root2').value = 'No real solution'
        }
        else {
            if(root=='0')
            {
                document.getElementById('root1').value = root1
                document.getElementById('root2').value = 'No Second Answer'
            }
            else {
                document.getElementById('root1').value = root1
                document.getElementById('root2').value = root1
                }
            }
    };



    document.getElementById('quadraticerase').onclick = function()
    {
        document.getElementById('quadraticform').reset();
        $('.error').hide();
    }

        document.getElementById('cubicerase').onclick = function()
    {
        document.getElementById('cubicform').reset();
        $('.error').hide();
    }



}
</script>

<style>
div.#wrapper
{
    text-align: center;
}
.error
{
    color: #FF0000;
}</style>

</head>

<body>
<div id="wrapper">
    <div id="quadratic">
        <form id="quadraticform">
            <h1>Quadratic</h1>
            a:<input id="variablea" value="" type="text">
            <br/>
            b:<input id="variableb" value="" type="text">
            <br />
            c:<input id="variablec" value="" type="text">
            <br />
            <input id="quadraticcalculate" value="Calculate!" type="button">
            <input id="quadraticerase" value="Clear" type="button">
            <br />
            <br />
            Roots:
            <br />
            <input id="root1" type="text" readonly>
            <br />
            <input id="root2" type="text" readonly>
            <p id="quadraticaerror" class="error">Error:  Variable a is not a valid integer!</p>
            <br />
            <p id="quadraticberror" class="error">Error:  Variable b is not a valid integer!</p>
            <br />
            <p id="quadraticcerror" class="error">Error:  Variable c is not a valid integer!</p>
        </form>
    </div>
    <div id="cubic">
        <form id="cubicform">
            <h1>Cubic</h1>
            a:<input id="variablea" value="" type="text">
            <br/>
            b:<input id="variableb" value="" type="text">
            <br />
            c:<input id="variablec" value="" type="text">
            <br />
            d:<input id="variabled" value="" type="text">
            <br />
            <input id="cubiccalculate" value="Calculate!" type="button">
            <input id="cubicerase" value="Clear" type="button">
            <br />
            <br />
            Roots:
            <br />
            <input id="root1" type="text" readonly>
            <br />
            <input id="root2" type="text" readonly>
            <p id="cubicaerror" class="error">Error:  Variable a is not a valid integer!</p>
            <br />
            <p id="cubicberror" class="error">Error:  Variable b is not a valid integer!</p>
            <br />
            <p id="cubiccerror" class="error">Error:  Variable c is not a valid integer!</p>
            <br />
            <p id="cubicderror" class="error">Error:  Variable d is not a valid integer!</p>
        </form>
    </div>
</div>
</body>
</html>
+2  A: 

* and / have same precedence and are left associative so what you have effectively got is

root = Math.pow(inputb,2) - 4 * inputa * inputc;
root1 = ((-inputb + Math.sqrt(root))/2)*inputa;
root2 = ((-inputb - Math.sqrt(root))/2)*inputa;

what you want is

root = Math.pow(inputb,2) - 4 * inputa * inputc;
root1 = (-inputb + Math.sqrt(root))/(2*inputa);
root2 = (-inputb - Math.sqrt(root))/(2*inputa);
tobyodavies
Oh wow, argh! How could I miss that! Thanks! For some reason, though, it still spits out wrong roots. For example, when inputting `a=1`, `b=1` and `c=0`, it spits out `x = 0` and `x = 0` as two separate and real roots. However, the real roots given `a, b, c` are `x = -1` and `x = 0`....
BOSS
possibly something to do with floating points and integer truncation (tho you would expect sqrt to always return a floating point), chuck in a couple of `1.0*` at the start of `root1=` and `root2=` and see if that fixes it
tobyodavies
i get the correct answers when running this in my JS console in chrome without the `1.0*` and same with firebug
tobyodavies
hmmm, what's up with that? Like with my example, you get `x=-1` and `x=0`?
BOSS
yes, with `inputa=inputb=1;` `inputc=0;` and then running those 3 lines i get `root1==0` and `root2==-1` how are you getting 1,1 and 0 into these variables, there could be a bug there...
tobyodavies
I've included the full code in case you spot something faster than I do..
BOSS
in that last else block in the onclick function - `document.getElementById('root1').value = root1;` `document.getElementById('root2').value = root1` you display the same root twice...
tobyodavies
Pardon my tardness, but thank you
BOSS