views:

74

answers:

5

Hi I'm about to add new functionality to application which I'm currently writting. I need to write a undo/redo fnctionality. However 90% of our application is ready and I don't know what is the best way to implementing this functionality without affectig(too much ) code which has been already created.

A: 

Couple of questions: What does the undo do? Does it undo all changes or only the last one?

In any case, you would first store the state of the input fields (initial state, or last desired position), then the undo button would take that state and apply it to the field.

Redo would be the same concept, but it would store the state previous to the undo.

Justice Erolin
Undo opeartion should be able to undo all operations step by step.
pieere
+5  A: 

There aren't many details here. However, Undo/Redo functionality is typically handled via some variation of the Command Pattern. Depending on your architecture, this could be a simple reworking of your basic functionality into "commands", or a major overhaul.

Reed Copsey
This is how you do it. Once everything your program does is funneled through instances of "commands" then you're 80% there.
Detmar
If the original architects/developers didn't have this in their minds when they first started designing the system, I'm leaning toward this being a major overhaul!
tster
@tster: It typically is a pretty major reworking - though it depends on how well architected the app is to begin with.
Reed Copsey
A: 

You'll need an undo/redo stack, and major changes to make everything aware of this stack.. I'm sorry, but magic doesn't exist :/

Onkelborg
A: 

There's a free library written by Rockford Lhotka for Business Objects that includes built in undo/redo functionality. I think he even implements it through an interface, so it should be "minimally invasive".

Joel B
A: 

As Reed Copsey says the most common pattern to implementing do/redo is Command Pattern (http://www.dofactory.com/Patterns/PatternCommand.aspx). The basic idea is to implement actions as commands that implemets some interface like this:

public interface ICommand  { public void Execute(); public void Undo(); }

Then You have a class (Control) that executes all the commands as a whole, such class must be composed by a group of commands, the when you execute the commands each command is pushed inside a Stack (by means the push() method), in the case you want to undo the actions then you take every element from the Stack (by means of pop() ) an executes its Undo() method.

public class Control {  
    private ArrayList<ICommand> commands  = new ArrayList<ICommand>();  
    private Stack<ICommand> stack = new Stack<ICommand>();  

    public Control() {      
        commands.add(new Command1());
        commands.add(new Command2());       
        commands.add(new Command3());       
    }

    public void Execute() {
        for(int index=0; index<=command.size(); index++) { command.Execute(); stack.push(command);}
    }
    public void Undo() 
    {
        while (!stack.empty()) {
            ICommand command = (ICommand)stack.pop();
            if (command != null) { command.Undo(); }        
        }       
    }   
}

Note: this is a very simple code, only for trying to clarify the ideas behind the Command Pattern.

ArceBrito