ansaurus

Question

Might be a quickie: Escape problems (I think) in an .innerHTML call

Answer 1

+1 A:

All I can guess is that you may want to try self-closing your BR tags: <br />

This is one of those situations that often vanish when you use a library like Prototype or jQuery for your DOM manipulation. Browser quirks are usually taken into account internally.

Diodeus 2009-02-20 17:56:10

I actually had them like that originally, but my validator yelled at me for it, haha. :(I love jQuery, and I'd have used it here, but I didn't feel the need - it's a very small script in the middle of an automatically generated page. If I can't find a workaround I'll definitely use it, though.

2009-02-20 17:59:21

Yeah, those IE error message are soooo helpful sometimes.

Diodeus 2009-02-20 18:00:23

Answer 2

A:

I created the following test case:

<html><head></head><body>
<script type="text/javascript">
function F(str) {
  var s = '';
  var c = '';
  var t = '';
  if (str == 'cat') {
    s = "cat";
    // c = "animal";
    c = 'Stuff<br><ul><li>listed stuff</li><li>more listed stuff</li><li>some more listed stuff</li></ul><br>bla bla<br>bla';
    t = "fluffy";
  }
  // ...
  document.getElementById("title").innerHTML = t;
  document.getElementById("category").innerHTML = c;
  document.getElementById("description").innerHTML = s;
}
</script>
<table border="1">
<tr><td><div id="title"></div></td></tr>
<tr><td><div id="category"></div></td></tr>
<tr><td><div id="description"></div></td></tr>
</table>
<form><input type="button" onclick="F('cat');"></form>
</body></html>

It appears to work correctly in Internet Explorer 7. Are you sure there isn't something you are doing in // ... that is causing your error? Have you confirmed this happens with every copy of Internet Explorer 7 (your copy may have an add-on, corrupt or outdated component or incorrect registry entry causing the error you are seeing). Have you narrowed the problem down to assigning the string to innerHTML using a simple and concise code sample such as that shown above?

Grant Wagner 2009-02-20 18:11:36

The content of // ... is just duplicates of what's there - more "if str == 'dog'" type of content. I tested it on another computer in the office, and it didn't work.The reason I think it's that line specifically is because running a debugger pointed the error toward "document .. HTML = c;".

2009-02-20 18:16:21

I routinely assign HTML 740 characters long, complete with comments and inline CSS to innerHTML in IE7 and it always works. I'm sure the HTML you supplied isn't what you are using, so start with a very simple example (c = '<span>test</span>';) and build up from there until it stops working.

Grant Wagner 2009-02-20 18:22:36

It actually is the same - well, kind of. The tags are the same; I just took the content out. So instead of "Stuff" it says "Welcome to this fabulous div!" or something like that. I'll try building up one section at a time, though.

2009-02-20 18:24:39

Update: I started simple - c = 'This is a <br />test.';and it broke. So I guess it's not that line, which puts it in the category of "this is too simple to break." How frustrating!

2009-02-20 18:28:40

Answer 3

+1 A:

Doh!

Sorry for wasting your time, guys - turns out it was totally unrelated. The line was breaking because of the div's id; since the HTML in the middle of the page, nested in a containing div generated by a content management system, apparently there was another div somewhere else in the page. Changing "div id=description" to "div id=dynDescription" solved it.

Thanks for the answers, though! Definitely appreciated.

2009-02-20 18:54:36

ansaurus

tags:

views:

answers:

Might be a quickie: Escape problems (I think) in an .innerHTML call

related questions