views:

177

answers:

4

I am rewriting code to handle some embedded communications and right now the protocol handling is implemented in a While loop with a large case/switch statement. This method seems a little unwieldy. What are the most commonly used flow control methods for implementing communication protocols?

A: 

For cases where you key off of a field in a protocol header to direct you to the next stage of processing for that protocol, arrays of function pointers can be used. You use the value from the protocol header to index into the array and call the function for that protocol.

You must handle all possible values in this array, even those which are not valid. Eventually you will get a packet containing the invalid value, either because someone is trying an attack or because a future rev of the protocol adds new values.

DGentry
A: 

If it is all one protocol being handled then a switch/case statement may be your best bet. However you should break all the individual message handlers into their own functions.

If your switch statement contains any code to actually handle the messages than you would be better off breaking them out.

If it is handling multiple similar protocols you could create a class to handle each one based off the same abstract class and when the connection comes in you could determine which protocol it is and create an instance of the appropriate handler class to decode and handle the communications.

Ryan Roper
A: 

I would think this depends largely on the language you are using, and what sort of data set objects you have available to you.

In python, for example, you could create a Dictionary object of all the different handling statements, and just iterate through that to find the right method/function to call.

Case/Switch statements aren't bad things, but if they get huge(like they can with massive amounts of protocol handlers) then they can become unwieldy to work with.

junkforce
+1  A: 

It sounds like the "while + switch/case" is a statemachine implementation. I believe that a well thought out statemachine is often the easiest and most readable way to implement a protocol.

When it comes to statemachines, breaking some of the traditional programming rules comes with the territory. Rules like "every function should be less than 25 lines" just don't work. One might even argue that statemachines are GOTOs in disguise.

mliesen