views:

1290

answers:

5

I have a bunch of strings that I need to sort. I think a std::vector would be the easiest way to do this. However, I've never used vectors before and so would like some help.

I just need to sort them alphanumerically, nothing special. Indeed, the string::compare function would work.

After that, how can I iterate through them to verify that they're sorted?

Here's what I have so far:

std::sort(data.begin(), data.end(), std::string::compare);

for(std::vector<std::string>::iterator i = data.begin(); i != data.end(); ++i)
{
    printf("%s\n", i.c_str);
}
+2  A: 

What is the question exactly? It seems everything is already there.

However you should probably use std::cout << *i << std::endl;

  1. i is an iterator == pointer to the data in the container, so * is needed
  2. c_str() is afaik a function of std::string and not a variable

The problems in your code do not relate to your question?

Some hints for you:

  • std::vector also overrides [] operator, so you can instead save the iterator hassle and use it like an array (iterate from 0 to < vector.size()).
  • You could use std::set instead, which is automatically sorting on insertion (binary tree), so you save the extra sorting.
  • Using a functor makes your output even more fun: copy(V.begin(), V.end(), ostream_iterator(cout, "\n"));
ypnos
+16  A: 

You can just do

std::sort(data.begin(), data.end());

And it will sort your strings. Then go through them checking whether they are in order

if(names.empty())
    return true; // empty vector sorted correctly
for(std::vector<std::string>::iterator i=names.begin(), j=i+1; 
        j != names.end(); 
        ++i, ++j)
    if(*i > *j)
        return false;
return true; // sort verified

In particular, std::string::compare couldn't be used as a comparator, because it doesn't do what sort wants it to do: Return true if the first argument is less than the second, and return false otherwise. If you use sort like above, it will just use operator<, which will do exactly that (i.e std::string makes it return first.compare(second) < 0).

Johannes Schaub - litb
Just for fun (and untested): Checking that the vector is sorted could be simplified to std::adjacent_find(names.begin(), names.end(), std::greater<std::string>()) == names.end()
Éric Malenfant
@Éric Malenfant - I have tested, it works
Darius Kucinskas
@Éric Malenfant, nicely done
Johannes Schaub - litb
A: 

For sort use:
std::sort or std::vector< std::string>::sort(..) method.
For check is sorted:
use std::is_sorted for check is sorted - http://www.sgi.com/tech/stl/is_sorted.html
or
std::adjacent_find( v.begin(), v.end(), std::greater< std::string >() ) == v.end()

for your case you could use default comparator

EDITED:
std::is_sorted is not standard stl function, it defined in sgi stl implementation.
Thanks @Brian Neal for this note.

bb
You shouldn't rely on that sgi site for info on the STL. It predates the standard. is_sorted isn't standard.
Brian Neal
edited, thank you, for this important note.
bb
+1  A: 

litb is correct, as always.

I just wanted to point out the more general point - anything that can be compared with < can be sorted with std::sort. I'll sometimes sneak an operator< member function into a struct, just so I can do this.

Mark Ransom
+1  A: 

Couldn't use use a std::set which is naturally a sorted container?

Joe