tags:

views:

8940

answers:

16

Hi guys,

I'm trying to do something like the following:

enum E;

void Foo(E e);

enum E {A, B, C};

which the compiler rejects. I've had a quick look on Google and the consensus seems to be "you can't do it", but I can't understand why. Can anyone explain? Many thanks.

Clarification 2: I'm doing this as I have private methods in a class that take said enum, and I do not want the enum's values exposed - so, for example, I do not want anyone to know that E is defined as

enum E { FUNCTIONALITY_NORMAL, FUNCTIONALITY_RESTRICTED, FUNCTIONALITY_FOR_PROJECT_X }

as project X is not something I want my users to know about.

So, I wanted to forward declare the enum so I could put the private methods in the header file, declare the enum internally in the cpp, and distribute the built library file and header to people.

As for the compiler - it's GCC.

+1  A: 

Seems it can not be forward-declared in GCC!

Interesting discussion here

Prakash
+5  A: 

There is indeed no such thing as a forward declaration of enum. As an enum's definition doesn't contain any code that could depend on other code using the enum, it's usually not a problem to define the enum completely when you're first declaring it.

If the only use of your enum is by private member functions, you can implement encapsulation by having the enum itself as a private member of that class. The enum still has to be fully defined at the point of declaration, that is, within the class definition. However, this is not a bigger problem as declaring private member functions there, and is not a worse exposal of implementation internals than that.

If you need a deeper degree of concealment for your implementation details, you can break it into an abstract interface, only consisting of pure virtual functions, and a concrete, completely concealed, class implementing (inheriting) the interface. Creation of class instances can be handled by a factory or a static member function of the interface. That way, even the real class name, let alone its private functions, won't be exposed.

Alexey Feldgendler
+1  A: 

Because the enum can be an integral size of varying size (the compiler decides which size a given enum has), the pointer to the enum can also have varying size, since it's an integral type (chars have pointers of a different size on some platforms for instance).

So the compiler can't even let you forward-declare the enum and user a pointer to it, because even there, it needs the size of the enum.

Carl Seleborg
+8  A: 

Forward declaring enums is non-standard, because pointers to different enum types are not guaranteed to be the same size. The compiler may need to see the definition to know what size pointers can be used with this type.

In practice, at least on all the popular compilers, pointers to enums are a consistent size. Forward declaration of enums is provided as a language extension by Visual C++, for example.

James Hopkin
-1. If your reasoning was correct, the same reasoning would imply that forward declarations of class types could not be used to create pointers to those types -- but they can.
j_random_hacker
+1. Reasoning is correct. The specific case is platforms where sizeof(char*) > sizeof(int*). Both can be underlying types for an enum, depending on range. Classes do not have underlying types so the analogy is false.
MSalters
@MSalters: "Underlying type" is indeed a property of an enum and not a class, but that's irrelevant -- the same thing that is done for classes *could* be done for enums without a contradiction arising. Namely, using full-size (i.e. char*) pointers, and allowing pointers to be used before definition.
j_random_hacker
@MSalters: Example: "struct S { int x; };" Now, sizeof (S*) *must* be equal to the size of any other pointer-to-struct, since C++ allows such a pointer to be declared and used prior to the definition of S...
j_random_hacker
@MSalters: ... On a platform where sizeof(char*) > sizeof(int*), using such a "full-size" pointer for this particular struct may be inefficient, but it dramatically simplifies coding -- and exactly the same thing could, and should, be done for enum types.
j_random_hacker
pointers to data and pointers to functions can be different sizes, but I'm fairly sure that data pointers have to round-trip (cast to another data pointer type, then back to the original, need to still work), which implies that all data pointers are the same size.
Ben Voigt
A: 

In answer to the clarification: If you use the enum internally only, why not declare it inside the class as private?

Konrad Rudolph
+1  A: 

I'd do it this way:

[in the public header]

typedef unsigned long E;

void Foo(E e);

[in the internal header]

enum Econtent { FUNCTIONALITY_NORMAL, FUNCTIONALITY_RESTRICTED, FUNCTIONALITY_FOR_PROJECT_X,
  FORCE_32BIT = 0xFFFFFFFF };

By adding FORCE_32BIT we ensure that Econtent compiles to a long, so it's interchangeable with E.

Laurie Cheers
Of course, this means that (A) the types of E and Econtent differ, and (B) on LP64 systems, sizeof(E) = 2 * sizeof(EContent). Trivial fix: ULONG_MAX, easier to read as well.
MSalters
+36  A: 

The reason the enum can't be forward declared is that without knowing the values, the compiler can't know the storage required for the enum variable. C++ Compiler's are allowed to specify the actual storage space based on the size necessary to contain all the values specified. If all that is visible is the forward declaration, the translation unit can't know what storage size will have been chosen - it could be a char or an int, or something else.


From Section 7.2.5 of the ISO C++ Standard:

The underlying type of an enumeration is an integral type that can represent all the enumerator values defined in the enumeration. It is implementation-defined which integral type is used as the underlying type for an enumeration except that the underlying type shall not be larger than int unless the value of an enumerator cannot fit in an int or unsigned int. If the enumerator-list is empty, the underlying type is as if the enumeration had a single enumerator with value 0. The value of sizeof() applied to an enumeration type, an object of enumeration type, or an enumerator, is the value of sizeof() applied to the underlying type.

Since the caller to the function must know the sizes of the parameters to correctly setup the call stack, the number of enumerations in an enumeration list must be known before the function prototype.

Update: In C++0X a syntax for foreward declaring enum types has been proposed and accepted. You can see the proposal at http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2008/n2764.pdf

KJAWolf
Now that your answer is accepted, Could you edit your answer?
Prakash
Note that the very _intent_ of defining an enum is to restrict it's possible values. Forward declaring trumps this.
xtofl
-1. Your reasoning cannot be correct -- otherwise, why are you allowed to forward-declare "class C;" and then declare a function prototype that takes or returns a C, before fully defining C?
j_random_hacker
My point is that, when declaring a function prototype, the compiler doesn't need to know a parameter's size, regardless of whether it is a class or an enum. Clearly it's useful to be able to specify incomplete class types here, and this works fine -- so why not incomplete enum types?
j_random_hacker
If this is the case, is it possible to declare the storage size in the forward declaration.
Grant Peters
@j_random: You can not use a class before it's fully defined - you can only use a pointer or a reference to that class and that's because their sizes and ways of operations do not depend on what the class is.
RnR
@RnR: Of course you cannot declare a variable of class C, or ask for sizeof (C), before C is defined, but the fact that you *can* declare pointers and references to C before it's defined limits compilation dependencies (fewer #includes == faster). It ought to be possible to do the same with enums.
j_random_hacker
The size of a reference or pointer to a class object is set by the compiler, and independent of the actual size of the object - it is the size of pointers and references. The enum is an object, and its size is needed for the compiler to access the correct storage.
KJAWolf
Logically it would be able to declare pointers/references to enums if we had forward-declaring enums, just as we can do with classes. It's just that you do not often deal with pointers to enums :)
Pavel Minaev
+1  A: 

My solution to your problem would be to either:

1 - use int instead of enums: Declare your ints in an anonymous namespace in your CPP file (not in the header):

namespace
{
   const int FUNCTIONALITY_NORMAL = 0 ;
   const int FUNCTIONALITY_RESTRICTED = 1 ;
   const int FUNCTIONALITY_FOR_PROJECT_X = 2 ;
}

As your methods are private, no one will mess with the data. You could even go further to test if someone sends you an invalid data:

namespace
{
   const int FUNCTIONALITY_begin = 0 ;
   const int FUNCTIONALITY_NORMAL = 0 ;
   const int FUNCTIONALITY_RESTRICTED = 1 ;
   const int FUNCTIONALITY_FOR_PROJECT_X = 2 ;
   const int FUNCTIONALITY_end = 3 ;

   bool isFunctionalityCorrect(int i)
   {
      return (i >= FUNCTIONALITY_begin) && (i < FUNCTIONALITY_end) ;
   }
}

2 : create a full class with limited const instantiations, like done in Java. Forward declare the class, and then define it in the CPP file, and instanciate only the enum-like values. I did something like that in C++, and the result was not as satisfying as desired, as it needed some code to simulate an enum (copy construction, operator =, etc.).

3 : As proposed before, use the privately declared enum. Despite the fact an user will see its full definition, it won't be able to use it, nor use the private methods. So you'll usually be able to modify the enum and the content of the existing methods without needing recompiling of code using your class.

My guess would be either the solution 3 or 1.

paercebal
+2  A: 

If you really don't want your enum to appear in your header file AND ensure that it is only used by private methods, then one solution can be to go with the pimpl principle.

It's a technique that ensure to hide the class internals in the headers by just declaring:

class A 
{
public:
    ...
private:
    void* pImpl;
};

Then in your implementation file (cpp), you declare a class that will be the representation of the internals.

class AImpl
{
public:
    AImpl(A* pThis): m_pThis(pThis) {}

    ... all private methods here ...
private:
    A* m_pThis;
};

You must dynamically create the implementation in the class constructor and delete it in the destructor and when implementing public method, you must use:

((AImpl*)pImpl)->PrivateMethod();

There are pros for using pimpl, one is that it decouple your class header from its implementation, no need to recompile other classes when changing one class implementation. Another is that is speeds up your compilation time because your headers are so simple.

But it's a pain to use, so you should really ask yourself if just declaring your enum as private in the header is that much a trouble.

Vincent Robert
struct AImpl; struct A { private: AImpl* pImpl; };
Roger Pate
A: 

You define an enumeration to restrict the possible values of elements of the type to a limited set. This restriction is to be enforced at compile time.

When forward declaring the fact that you will use a 'limited set' later on doesn't add any value: subsequent code needs to know the possible values in order to benefit from it.

Although the compiler is concerned about the size of the enumerated type, the intent of the enumeration gets lost when you forward declare it.

xtofl
No, subsequent code need not know the values for this to be useful -- in particular, if the subsequent code is merely a function prototype taking or returning enum parameters, the size of the type is not important. Using forward declaration here can remove build dependencies, speeding compilation.
j_random_hacker
You're right. The intent is not to obey the values, but the type. Solved with 0x Enum types.
xtofl
+1  A: 

There's some dissent since this got bumped (sort of), so here's some relevant bits from the standard. Research shows that the standard doesn't really define forward declaration, nor does it explicitly state that enums can or can't be forward declared.

First, from dcl.enum, section 7.2:

The underlying type of an enumeration is an integral type that can represent all the enumerator values defined in the enumeration. It is implementation-defined which integral type is used as the underlying type for an enumeration except that the underlying type shall not be larger than int unless the value of an enumerator cannot fit in an int or unsigned int. If the enumerator-list is empty, the underlying type is as if the enumeration had a single enumerator with value 0. The value of sizeof() applied to an enumeration type, an object of enumeration type, or an enumerator, is the value of sizeof() applied to the underlying type.

So the underlying type of an enum is implementation-defined, with one minor restriction.

Next we flip to the section on "incomplete types" (3.9), which is about as close as we come to any standard on forward declarations:

A class that has been declared but not defined, or an array of unknown size or of incomplete element type, is an incompletely-defined object type.

A class type (such as "class X") might be incomplete at one point in a translation unit and complete later on; the type "class X" is the same type at both points. The declared type of an array object might be an array of incomplete class type and therefore incomplete; if the class type is completed later on in the translation unit, the array type becomes complete; the array type at those two points is the same type. The declared type of an array object might be an array of unknown size and therefore be incomplete at one point in a translation unit and complete later on; the array types at those two points ("array of unknown bound of T" and "array of N T") are different types. The type of a pointer to array of unknown size, or of a type defined by a typedef declaration to be an array of unknown size, cannot be completed.

So there, the standard pretty much laid out the types that can be forward declared. Enum wasn't there, so compiler authors generally regard forward declaring as disallowed by the standard due to the variable size of its underlying type.

It makes sense, too. Enums are usually referenced in by-value situations, and the compiler would indeed need to know the storage size in those situations. Since the storage size is implementation defined, many compilers may just choose to use 32 bit values for the underlying type of every enum, at which point it becomes possible to forward declare them. An interesting experiment might be to try forward declaring an enum in visual studio, then forcing it to use an underlying type greater than sizeof(int) as explained above to see what happens.

Dan Olson
note that it explicitly disallows "enum foo;" in 7.1.5.3/1 (but as with everything, as long as the compiler warns, it may still compile such code, of course)
Johannes Schaub - litb
Thanks for pointing it out, that's a really esoteric paragraph and it might take me a week to parse it. But it's good to know it's there.
Dan Olson
no worries.some standard paragraphs are really strange :) well,an elaborated type specifier is something where you specify a type,but also specify something more to make it unambiguous. e.g "struct X" instead of "X", or "enum Y" instead of only "Y".you need it to assert something is really a type.
Johannes Schaub - litb
so you can use it like this: "class X * foo;" if X wasn't forward declared yet. or "typename X::foo" in a template for disambiguation. or "class link obj;" if there is a function "link" in the same scope that would shadow the class having the same name.
Johannes Schaub - litb
in 3.4.4 it says they are used if some non-type name hides a type name. that's where they are most often used, apart from forward declaring like "class X;" (here it is the sole constitute of a declaration). it talks about them in non-templates here. however, 14.6/3 lists a use of them in templates.
Johannes Schaub - litb
hope that helps. cheers :)
Johannes Schaub - litb
+2  A: 

Just noting that the reason actually is that the size of the enum is not yet known after forward declaration. Well, you use forward declaration of a struct to be able to pass a pointer around or refer to an object from a place that's refered to in the forward declared struct definition itself too.

Forward declaring an enum would not be too useful, because one would wish to be able to pass around the enum by-value. You couldn't even have a pointer to it, because i recently got told some platforms use pointers of different size for char than for int or long. So it all depends on the content of the enum.

The current C++ Standard explicitly disallows doing something like

enum X;

(in 7.1.5.3/1). But the next C++ Standard due to next year allows the following, which convinced me the problem actually has to do with the underlying type:

enum X : int;

It's known as a "opaque" enum declaration. You can even use X by value in the following code. And its enumerators can later be defined in a later redeclaration of the enumeration. See 7.2 in the current working draft.

Johannes Schaub - litb
A: 
赵如飞
A: 

In my projects, I adopted the Namespace-Bound Enumeration technique to deal with enums from legacy and 3rd-party components. Here is an example:

forward.h:

namespace type
{
    class legacy_type;
    typedef const legacy_type& type;
}

enum.h:

// May be defined here or pulled in via #include.
namespace legacy
{
    enum evil { x , y, z };
}


namespace type
{
    using legacy::evil;

    class legacy_type
    {
    public:
        legacy_type(evil e)
            : e_(e)
        {}

        operator evil() const
        {
            return e_;
        }

    private:
        evil e_;
    };
}

foo.h:

#include "forward.h"

class foo
{
public:
    void f(type::type t);
};

foo.cc:

#include "foo.h"

#include <iostream>
#include "enum.h"

void foo::f(type::type t)
{
    switch (t)
    {
        case legacy::x:
            std::cout << "x" << std::endl;
            break;
        case legacy::y:
            std::cout << "y" << std::endl;
            break;
        case legacy::z:
            std::cout << "z" << std::endl;
            break;
        default:
            std::cout << "default" << std::endl;
    }
}

main.cc:

#include "foo.h"
#include "enum.h"

int main()
{
    foo fu;
    fu.f(legacy::x);

    return 0;
}

Note that the foo.h header does not have to know anything about legacy::evil. Only the files that use the legacy type legacy::evil (here: main.cc) need to include enum.h.

Matthias Vallentin
+11  A: 

Forward declaration of enums is also possible in C++0x. Previously, the reason enum types could not be forward declared is because the size of the enumeration depends on its contents. As long as the size of the enumeration is specified by the application, it can be forward declared:

enum Enum1;                   //Illegal in C++ and C++0x; no size is explicitly specified.
enum Enum2 : unsigned int;    //Legal in C++0x.
enum class Enum3;             //Legal in C++0x, because enum class declarations have a default type of "int".
enum class Enum4: unsigned int; //Legal C++0x.
enum Enum2 : unsigned short;  //Illegal in C++0x, because Enum2 was previously declared with a different type.

Not really adding anything new, just that it is possible in 0x.

+5  A: 

Forward declaring things in C++ is very useful because it dramatically speeds up compilation time. You can forward declare several things in C++ including: struct, class, function, etc...

But can you forward declare an enum in C++?

No you can't.

But why not allow it? If it were allowed you could define your enum type in your header file, and your enum values in your source file. Sounds like it should be allowed right?

Wrong.

In C++ there is no default type for enum like there is in C# (int). In C++ your enum type will be determined by the compiler to be any type that will fit the range of values you have for your enum.

What does that mean?

It means that your enum's underlying type cannot be fully determined until you have all of the values of the enum defined. Which mans you cannot separate the declaration and definition of your enum. And therefore you cannot forward declare an enum in C++.

The ISO C++ standard S7.2.5:

The underlying type of an enumeration is an integral type that can represent all the enumerator values defined in the enumeration. It is implementation-defined which integral type is used as the underlying type for an enumeration except that the underlying type shall not be larger than int unless the value of an enumerator cannot fit in an int or unsigned int. If the enumerator-list is empty, the underlying type is as if the enumeration had a single enumerator with value 0. The value of sizeof() applied to an enumeration type, an object of enumeration type, or an enumerator, is the value of sizeof() applied to the underlying type.

You can determine the size of an enumerated type in C++ by using the sizeof operator. The size of the enumerated type is the size of its underlying type. In this way you can guess which type your compiler is using for your enum.

What if you specify the type of your enum explicitly like this:

enum Color : char { Red=0, Green=1, Blue=2};
assert(sizeof Color == 1);

Can you then forward declare your enum?

No. But why not?

Specifying the type of an enum is not actually part of the current C++ standard. It is a VC++ extension. It will be part of C++0x though.

Source

Brian R. Bondy