I need to push into an array values based on a specific condition, what is the correct way to do this?

Question

I have a forcycle that contains a condition (and an incremental value i):

if(condition)){$arr[$i] = array("value" => $node->nodeValue));}
else{$arr[$i] = array("string" => $node->nodeValue);}

In the end I need to have an array like this:

    Array ( [1] => Array ( [string] => abc [value] => 0,999 ) 
            [2] => Array ( [string] => meh [value] => 0,123 ) 
            [x] => Array ( [string] => xxx [value] => xxx ) )

I understand that my code doesn't work, I think I should use array_push, but I was wondering is there are better way to achieve this

Thank you very much

Answer 1

You can write it somewhat more concise using the ?: operator:

$fieldname = ($condition? "value" : "string"); 
$arr[$i][$fieldname] = $node->nodeValue ;

Answer 2

I'm sorry, the question is not very clear.. Is that what you are trying to do?

$result = array();
foreach( $nodes as $node ) 
{
    $type = 'value';
    if( is_string( $node->nodeValue ) )
    {
        $type = 'string';
    }

    $result[][$type] = $node->nodeValue;
}