FlowDocument Memory Issue in C#

Question

I am currently attempting to deal with an issue with releasing a FlowDocument resources. I am loading an rtf file and putting it into a FlowDocument with TextRange.Load. I noticed that after it does this it holds onto those resources and GC doesn't collect it. I have ran a memory profiler and have seen that this is true. I have also narrowed it down to were I load actually put the rtf into the FlowDocument. If I dont do that, then everything is ok. So I know this is the issue.

I am hoping for some guidance to what how I can solve this problem. Here is the code that loads the rtf and everything. I have commented all of the other code out and even put it in its own scope as well as tried GC.Collect(). Any help is greatly appreciated.

EDIT: Here is my code in full at the moment. I have taken out everything else except for the bare essentials to get it running. The problem is still there. As you can see the FlowDocument and TextRange are not referenced anywhere else.

    public LoadRTFWindow(string file)
    {
        InitializeComponent();

        using (FileStream reader = new FileStream(file, FileMode.Open))
        {
            FlowDocument doc = new FlowDocument();
            TextRange range = new TextRange(doc.ContentStart, doc.ContentEnd);
            range.Load(reader, System.Windows.DataFormats.Rtf);
        }
        GC.Collect();
        GC.WaitForPendingFinalizers();
        GC.Collect();
    }

I found this post, which I was hoping would help me solve my problem but I had no luck with it. Any type of help is greatly appreciated. Thank you.

EDIT: I figure I should mention the major way I am checking this. I have Windows Task Manager open and am watching the memory usage my application's process is using. When I run the above code the application goes from 40,000K to 70,000K while doing the TextRange.Load() (this is a large 400 page RTF) and once that finishes it drops down to 61,000K and stays there. My expectation is that it would drop back down to 40,000K or at least very close to it.

As I mentioned earlier I used a memory profiler and saw that there were LOTS of Paragraph, Run..ect. objects still Alive afterwards.

Answer 1

Make sure that the Parent of the FlowDocument isn't hanging around, see here. "Instantiating a FlowDocument automatically spawns a parent FlowDocumentPageViewer that hosts the content." If that control is hanging around it could be the source of your problem.

Answer 2

FlowDocument uses System.Windows.Threading.Dispatcher to free all resources. It doesn't use finalizers because finalizers will block current thread until all resources will be free. So the user may see some UI freezings and so on. Dispatchers are running in background thread and have less impact on the UI.
So calling GC.WaitForPendingFinalizers(); has no influence on this. You just need to add some code to wait and allow Dispatchers to finish their work. Just try to add something like Thread.CurrentThread.Sleep(2000 /* 2 secs */);

EDIT: It seems to me that you found this problem during debugging of some application. I wrote the following very simple test case (console program):

 static void Main(string[] args)
 {
  Console.WriteLine("press enter to start");
  Console.ReadLine();

  var path = "c:\\1.rtf";

  for (var i = 0; i < 20; i++)
  {
   using (var stream = new FileStream(path, FileMode.Open))
   {
    var document = new FlowDocument();
    var range = new TextRange(document.ContentStart, document.ContentEnd);

    range.Load(stream, DataFormats.Rtf);
   }
  }

  Console.WriteLine("press enter to run GC.");
  Console.ReadLine();

  GC.Collect();
        GC.WaitForPendingFinalizers();

  Console.WriteLine("GC has finished .");
  Console.ReadLine();
 }

I've tried to reproduce the problem. I run it several times and it was working perfectly - there were no leaks (about 3,2Kb all of the time and 36 handles). I couldn't reproduce it until I run this program in debug mode in the VS (just f5 instead of ctrl+f5). I received 20,5Kb at the beginning, 31,7Kb after loading and before GC and 31Kb after GC. It looks similar to your results.
So, could you please try to reproduce this problem running in release mode not under the VS?

Answer 3

GC.Collect() by itself won't collect everything, you need to run:

GC.Collect();
GC.WaitForPendingFinalizers();
GC.Collect();

Also, I've found the runtime doesn't always release collected memory right away, you should check the actual heap size instead of relying on task manager.

Answer 4

Consider releasing that file handle. Also consider using the "using" statement instead of calling IDisposable.Dispose (no pun intended).

Answer 5

I have yet been able to solve this. If anyone has any other suggestions I am very interested in hearing them. I would put a bounty of this but I dont think I have enough reputation. Thanks.

Answer 6

I tried to reproduce your problem, but it doesn't happen on my machine.

Task Manager shows working set size, which isn't an accurate representation of a program's memory usage. Try using perfmon instead.

1. Start -> Run -> perfmon.msc
2. Add .NET CLR Memory/#Bytes in All Heaps for your application

Now repeat the experiment and check if that counter keeps going up. If it doesn't, it means you aren't leaking any managed memory.

Answer 7

If I've confirmed that there's a memory leak, here's what I would do to debug the problem.

1. Install Debugging Tools for Windows from http://www.microsoft.com/whdc/devtools/debugging/installx86.mspx#a
2. Fire up Windbg from the installation directory.
3. Launch your application and do the operations that leak memory.
4. Attach Windbg to your application (F6).
5. Type .loadby sos mscorwks
6. Type !dumpheap -type FlowDocument
7. Check the result of the above command. If you see multiple FlowDocuments, for each value of the first column (which contains the address), do

Type !gcroot <value of first column>

That should show you who's holding on to the reference.

Answer 8

I had previously done up #7. It was the first time I used Windbg and so I didn't know what to do with the address to find the references. Here is what I got.

 Address       MT     Size
0131c9c0 55cd21d8       84     
013479e0 55cd21d8       84     
044dabe0 55cd21d8       84     
total 3 objects
Statistics:
      MT    Count    TotalSize Class Name
55cd21d8        3          252 System.Windows.Documents.FlowDocument
Total 3 objects
0:011> !gcroot 0131c9c0
Note: Roots found on stacks may be false positives. Run "!help gcroot" for
more info.
Scan Thread 0 OSTHread 47c
Scan Thread 2 OSTHread be8
Scan Thread 4 OSTHread 498
DOMAIN(001657B0):HANDLE(WeakSh):911788:Root:0131ff98(System.EventHandler)->
0131fcd4(System.Windows.Documents.AdornerLayer)->
012fad68(MemoryTesting.Window2)->
0131c9c0(System.Windows.Documents.FlowDocument)
DOMAIN(001657B0):HANDLE(WeakSh):911cb0:Root:0131ca90(MS.Internal.PtsHost.PtsContext)->
0131cb14(MS.Internal.PtsHost.PtsContext+HandleIndex[])->
0133d668(MS.Internal.PtsHost.TextParagraph)->
0131c9c0(System.Windows.Documents.FlowDocument)
DOMAIN(001657B0):HANDLE(WeakSh):9124a8:Root:01320a2c(MS.Internal.PtsHost.FlowDocumentPage)->
0133d5d0(System.Windows.Documents.TextPointer)->
0131ca14(System.Windows.Documents.TextContainer)->
0131c9c0(System.Windows.Documents.FlowDocument)

(I put it in a code block for easier reading). This is after I closed the window. So it looks like it is being referenced by a few things. Now that I know this how do I go about freeing up these references so they can release the FlowDocument.

Thanks for your help. I feel like I am finally gaining some ground.