views:

1606

answers:

11

In this code sample, is there any way to continue on the outer loop from the catch block?

while
{
   // outer loop

   while
   {
       // inner loop
       try
       {
           throw;
       }
       catch 
       {
           // how do I continue on the outer loop from here?
           continue;
       }
   }
}
+6  A: 

Swap the try/catch structure with the inner while loop:

while {
  try {
    while {
      throw;
    }
  }
  catch {
    continue;
  }
}
Welbog
+4  A: 

No.
I suggest, extracting the inner loop into a separate method.

while
{
   // outer loop
       try
       {
           myMethodWithWhileLoopThatThrowsException()
       }
       catch 
       {
           // how do I continue on the outer loop from here?
           continue;
       }
   }
}
shahkalpesh
This is problematic because the separate metod will not have access to existing local variables.
zvrba
That's why Microsoft gave us function parameters.
Welbog
pass the variables as parameters, or if side-effects are necessary, send it through as an anonymous delegate to be executed in the method. Then the compiler will create a closure, preserving your local scope.
Michael Meadows
+12  A: 

You can use a break; statement.

while
{
   while
   {
       try
       {
           throw;
       }
       catch 
       {
           break;
       }
   }
}

Continue is used to jump back to the top of the current loop.

If you need to break out more levels than that you will either have to add some kind of 'if' or use the dreaded/not recommended 'goto'.

Jake Pearson
The problem with this method is if there is extra work that needs to be done between the end of the inner loop and the end of the outer loop, it will be done when calling `break`, but wouldn't be done when calling `continue`. You'd need a flag if you need that code to not be executed. I'm not saying that this answer is wrong (heck, I upvoted it), I'm saying that it's deceptively simple.
Welbog
+2  A: 

Use break in the inner loop.

Marco Mustapic
+1  A: 

You just want to break from the inner which would continue the outer.

while
{
   // outer loop

   while
   {
       // inner loop
       try
       {
           throw;
       }
       catch 
       {
           // how do I continue on the outer loop from here?
           break;
       }
   }
}
David Basarab
A: 

I think the best way to accomplish this would be to use the break statement. Break ends the current loop and continues execution from where it ends. In this case, it would end the inner loop and jump back into the outer while loop. This is what your code would look like:

while
{
   // outer loop

   while
   {
       // inner loop
       try
       {
           throw;
       }
       catch 
       {
           // break jumps to outer loop, ends inner loop immediately.
           break; //THIS IS THE BREAK
       }
   }
}

I believe that is what you were looking to be accomplished, correct? Thanks!

Maxim Zaslavsky
A: 

don't forget the optional 'finally' block on your 'try'...'catch' structures; if there's something you require to happen.

Hardryv
+21  A: 

"continue" and "break" are nothing more than a pleasant syntax for a "goto". Apparently by giving them cute names and restricting their usages to particular control structures, they no longer draw the ire of the "all gotos are all bad all the time" crowd.

If what you want to do is a continue-to-outer, you could simply define a label at the top of the outer loop and then "goto" that label. If you felt that doing so did not impede the comprehensibility of the code, then that might be the most expedient solution.

However, I would take this as an opportunity to consider whether your control flow would benefit from some refactoring. Whenever I have conditional "break" and "continue" in nested loops, I consider refactoring.

Consider:

successfulCandidate = null;
foreach(var candidate in candidates)
{
  foreach(var criterion in criteria)
  {
    if (!candidate.Meets(criteria))
    {  // TODO: no point in continuing checking criteria.
       // TODO: Somehow "continue" outer loop to check next candidate
    }
  }
  successfulCandidate = candidate;
  break;
}
if (successfulCandidate != null) // do something

Two refactoring techniques:

First, extract the inner loop to a method:

foreach(var candidate in candidates)
{
  if (MeetsCriteria(candidate, criteria))
  { 
      successfulCandidate = candidate;
      break;
  }
}

Second, can all the loops be eliminated? If you are looping because you are trying to search for something, then refactor it into a query.

var results = from candidate in candidates 
              where criteria.All(criterion=>candidate.Meets(criterion))
              select candidate;
var successfulCandidate = results.FirstOrDefault();
if (successfulCandidate != null)
{
  do something with the candidate
}

If there are no loops then there is no need to break or continue!

Eric Lippert
+1 Well said...
Andrew Hare
+1 for "...extract the inner loop to a method." I require lot of justification in code reviews when I see nested loops. They usually hurt readability, maintainability, and stability. OP's question can be solved with a simple "return" or "throw" (thereby not relying on gotos in any way).
Michael Meadows
props for the refactoring comment.
ryansstack
Wow. comes straight from the source :)
shahkalpesh
Absolutely. When you think you need a `goto`, first stop for a moment and ponder if you really do. If you still need a `goto`, then just use it - it's in the language for a reason. It's not inherently evil either - it just commonly appears in evil patterns, and therefore should serve as a signal to stop and try to spot such patterns (and not to plunge into "OMG `goto` this is all wrong" panic).
Pavel Minaev
Goto is not inherently evil, but it is a gateway drug to bad, lazy code. Of all of the ways to control flow, it's *usually* the worst.
Michael Meadows
+1 well said. Your code example is elegant.
Chuck Conway
A: 

Use an own exception type, e.g., MyException. Then:

while
{
   try {
   // outer loop
   while
   {
       // inner loop
       try
       {
           throw;
       }
       catch 
       {
           // how do I continue on the outer loop from here?
           throw MyException;
       }
   }
   } catch(MyException)
   { ; }
}

This will work for continuing and breaking out of several levels of nested while statements. Sorry for bad formatting ;)

zvrba
You hurt my feelings, using exceptions for no other purpose than flow control. No downvote, just hurt feelings. :(
Michael Meadows
This makes me want to vomit everywhere
John Rasch
That's a little more emphatic than "hurt my feelings."
Michael Meadows
+3  A: 
    while
    {
       // outer loop

       while
       {
           // inner loop
           try
           {
               throw;
           }
           catch 
           {
               // how do I continue on the outer loop from here?
               goto REPEAT;
           }
       }
       // end of outer loop
REPEAT:
    }

Problem solved. (what?? Why are you all giving me that dirty look?)

ryansstack
A: 
using System;

namespace Examples
{

    public class Continue : Exception { }
    public class Break : Exception { }

    public class NestedLoop
    {
        static public void ContinueOnParentLoopLevel()
        {
            while(true)
            try {
               // outer loop

               while(true)
               {
                   // inner loop

                   try
                   {
                       throw new Exception("Bali mu mamata");
                   }
                   catch (Exception)
                   {
                       // how do I continue on the outer loop from here?

                       throw new Continue();
                   }
               }
            } catch (Continue) {
                   continue;
            }
        } 
    }

}

}