views:

283

answers:

10

The result of all of the division equations in the below for loop is 0. How can I get it to give me a decimal e.g.:

297 / 315 = 0.30793650793650793650793650793651

Code:

using System;

namespace TestDivide
{
    class Program
    {
        static void Main(string[] args)
        {

            for (int i = 0; i <= 100; i++)
            {
                decimal result = i / 100;
                long result2 = i / 100;
                double result3 = i / 100;
                float result4 = i / 100;
                Console.WriteLine("{0}/{1}={2} ({3},{4},{5}, {6})", i, 100, i / 100, result, result2, result3, result4);
            }
            Console.ReadLine();
        }
    }
}

Answer:

Thanks Jon and everyone, this is what I wanted to do:

using System;

namespace TestDivide
{
    class Program
    {
        static void Main(string[] args)
        {
            int maximum = 300;

            for (int i = 0; i <= maximum; i++)
            {
                float percentage = (i / (float)maximum) * 100f;
                Console.WriteLine("on #{0}, {1:#}% finished.", i, percentage);
            }
            Console.ReadLine();
        }
    }
}
A: 

Because i is a int value and you divide by an integer so the result is an integer ! and so you need to divide by 100.0 to have an implicit cast in float or specify 100f or 100d

Matthieu
+9  A: 

Try

i / 100.0
Lloyd
+1. It is that simple ;)
AnthonyWJones
This answer would get an upvote from me if it also explained *why* this would work ;o)
Fredrik Mörk
+4  A: 

because i is an int: i / 100 performs integer division, then the result, that is always 0, is casted to the target type. You need to specify at least one non-int literal in your expression:

i / 100.0
dfa
+15  A: 

You're using int/int, which does everything in integer arithmetic even if you're assigning to a decimal/double/float variable.

Force one of the operands to be of the type you want to use for the arithmetic.

for (int i = 0; i <= 100; i++)
{
    decimal result = i / 100m;
    long result2 = i / 100;
    double result3 = i / 100d;
    float result4 = i / 100f;
    Console.WriteLine("{0}/{1}={2} ({3},{4},{5}, {6})", 
                      i, 100, i / 100d, result, result2, result3, result4);
}

Results:

0/100=0 (0,0,0, 0)
1/100=0.01 (0.01,0,0.01, 0.01)
2/100=0.02 (0.02,0,0.02, 0.02)
3/100=0.03 (0.03,0,0.03, 0.03)
4/100=0.04 (0.04,0,0.04, 0.04)
5/100=0.05 (0.05,0,0.05, 0.05)

(etc)

Note that that isn't showing the exact value represented by the float or the double - you can't represent 0.01 exactly as a float or double, for example. The string formatting is effectively rounding the result. See my article on .NET floating binary point for more information as well as a class which will let you see the exact value of a double.

I haven't bothered using 100L for result2 because the result would always be the same.

Jon Skeet
+1  A: 

Because i is an integer and 100 is an integer...so you have an integer division

Try (decimal)i / 100.0 instead

Scoregraphic
+1  A: 

No matter where you store it, an integer divided by an integer will always be an integer.

A: 

this is integer division whatever the type of variable you storing in, so int / int = int

Ahmed Said
A: 
double result3 = ((double)i) / 100;
Steve Gilham
A: 

You need to force a floating point operation "double / double" instead of an "int / int"

double result = (double)297 / (double)315 ;
Tormod
+3  A: 

I know that this is not the point of the question... but I think that 297.0 / 315 is 0.942857142857143 rather than 0.30793650793650793650793650793651.

:)

headsling