Which has better job opportunities WinForms or Web Based. I am well versed in WinForms but when I try using web based applications I find them difficult. I like WinForms where I get events, message boxes, etc which are easy to use.
Which has better job opportunities?
From what I've seen, web has more active job opportunities, at least in my area.
If you want to develop on the desktop, I'd strongly recommend trying to learn WPF, as it also seems to be growing. This knowledge will also translate well to Silverlight development, which is growning strongly both for web and now for business applications.
Your best bet is to have in-depth familiarity with both...I would also add WPF to your list as it is set to replace WinForms development someday (may not be in the near future).
It all depends on what you are looking for. Web based apps are a different model than win form apps, but I definitely would encourage you to explore both. Knowing the programming models of both can help you to approach problems in more efficient ways and come up with better solutions in the end.
On another note, winForms is a bit of a dying art. WPF is the new push and it has a more web-like model and feel to it, although they are not the same thing by any means.
As far as job opportunities go, you can find work in any of the areas, but if you want to progress your career, I would suggest learning it all. Plus, you'll be more marketable in the end by having a broader knowledge base to pull from for your potential employers.