Can you refactor this ?
private void ClearUserDataFields()
{
var textBoxes = this.Controls.OfType<TextBox>();
foreach (var txtBoxControl in textBoxes)
{
txtBoxControl.Text = String.Empty;
}
}
Isn't there anyway to do this in one LOC ?
it looks nice to me, there are no duplications, no code smells (like typeof), etc
You could rename it to ClearUserDataFields to fix what is likely to be a typo in the name. Other than that, it looks fine to me.
this.Controls.OfType<TextBox>().ToList().ForEach(
delegate(TextBox t){ t.Text = String.Empty;}
);
Why on Earth though?
Well the "this" qualifier is redundant :) you can remove it
and since you have a tag lambda-expressions here you go
private void ClearUserDataFields()
{
Controls.OfType<TextBox>().ToList().ForEach(txtBoxControl => txtBoxControl.Text = string.Empty);
}
private void ClearUserDataFileds()
{
foreach (var txtBoxControl in this.Controls.OfType<TextBox>())
{
txtBoxControl.Text = String.Empty;
}
}
or
// think it's slower then previous one because of ToList call
private void ClearUserDataFileds()
{
this.Controls.OfType<TextBox>().ToList().ForEach(tb => tb.Text = String.Empty);
}
Oh, BTW, I love using MVVM so if this was a smart client app, I'd remove the coupling between the clearing logic and the actual controls. Instead you would be clearing your VM properties, which would be bound to the controls.
Ok because its SO important to see this in one line of code, here's your answer and it doesn't use a ToList():
foreach (var tb in Controls.OfType<TextBox>()) tb.Text = String.Empty;
foreach (var control in Controls.OfType<TextBox>())
control.Text = String.Empty;
ToList/lambda/ForEach are really redundant here and especially because this code have strong side effects so no point expressing imperative loop with side effect via a functional call.