views:

849

answers:

5

ok, its a little more complicated than the question.

class A
{
   static int needsToBeThreadSafe = 0;

   public static void M1()
   {
     needsToBeThreadSafe = RandomNumber();
   }

   public static void M2()
   {
     print(needsToBeThreadSafe);
   }
}

now i require that between M1() and M2() calls 'needsToBeThreadSafe' stays Thread Safe.

+2  A: 
class A
{
   static int needsToBeThreadSafe = 0;
   static object statObjLocker = new object();

   public static void M1()
   {
       lock(statObjLocker)
       {
          needsToBeThreadSafe = RandomNumber();
       }
   }

   public static void M2()
   {
       lock(statObjLocker)
       {
          print(needsToBeThreadSafe);
       }
   }
}
ArsenMkrt
+2  A: 

You have two choices: the easiest given your presented code is the volatile keyword. declare needsToBeThreadSafe as static volatile int and that will guarantee that any thread that references that variable will get the "latest" copy, and the variable won't be cached within your code.

That being said, if you want to more generally ensure that M1() and M2() execute "atomically" (or at least exclusively of each other), then you want to use a lock. The cleanest syntax is with a "lock block", like this:

private static object locker = new Object();

//..

public static void M1()
{
    lock(locker)
    {
        //..method body here
    }
}

public static void M2()
{
    lock(locker)
    {
        //..method body here
    }
}

As to which approach to take, that's up to you and should be determined by the code. If all you need is to ensure that a member assignment gets propagated to all threads and isn't cached, then the volatile keyword is simpler and will do the job just fine. If it's beyond that, you may want to go with the lock.

Adam Robinson
A: 

Sound like you need a Volatile member.

static volatile int needsToBeThreadSafe = 0;
C. Ross
A: 

What you might be trying to ask about is the [ThreadStatic] attribute. If you want each thread that uses the class A to have its own separate value of needsToBeThreadSafe then you just need to decorate that field with the [ThreadStatic] attribute.

For more info refer to the MSDN documentation for ThreadStaticAttribute.

paracycle
I guess everyone else was also right, but for my situation this works perfectly.
Binder
OK, but ThreadStatic is something else than ThreadSafe.
Henk Holterman
Somehow, I just realized that what he is really after is a value that is not shared between Threads. Besides, ThreadStatic **is** thread-safe since actually no two threads access the same variable (even though it looks like they are).
paracycle
@paracycle: Good job on answering the question, but eliminating the potential for conflict by creating local copies means that this is, by definition, not "thread safe". While it isn't "unsafe", thread safety means that it properly manages multiple threads dealing with the *same* resource; I wouldn't say that copying the resource is a means of doing that.
Adam Robinson
I **do** get your points and I don't want to needlessly extend the conversation, but my understanding of "thread-safe" is if a piece of code is safe to run simultaneously under multiple threads. "Thread-local storage" is a trivial implementation of that definition and might not suit your needs if you actually need shared data. If what you need is multiple threads of execution without threads stepping on each others' feet, and "thread-local storage" satisfies your needs then it's the way to go. Besides, the Wikipedia article (http://en.wikipedia.org/wiki/Thread_safety) seems to agree with me.
paracycle
A: 

You can also use the ReaderWriterLockSlim, that is more efficient for multiple reads and less writes:

static int needsToBeThreadSafe = 0;
static System.Threading.ReaderWriterLockSlim rwl = new System.Threading.ReaderWriterLockSlim();

public static void M1()
{
    try
    {
        rwl.EnterWriteLock();
        needsToBeThreadSafe = RandomNumber();
    }
    finally
    {
        rwl.ExitWriteLock();
    }

}

public static void M2()
{
    try
    {
        rwl.EnterReadLock();
        print(needsToBeThreadSafe);
    }
    finally
    {
        rwl.ExitReadLock();
    }
}
HuBeZa