How to access controls that is in the panel in c#

Question

I use a panel in c# winforms and fill the panel with the no of picture box using loop. like this eg panel name is panal

foreach (string s in fileNames)
{            
    PictureBox pbox = new new PictureBox();
    pBox.Image = Image.FromFile(s);
    pbox.Location = new point(10,15);
    .
    .
    .
    .
    this.panal.Controls.Add(pBox);
}

now i want to change the location of picturebox in anothe mathd. The problem is that how can now i access the pictureboxes so that i change the location of them. i try to use the followin but it is not success.

foreach (Control p in panal.Controls)
                if (p.GetType == PictureBox)
                   p.Location.X = 50;

But there is error. The error is:

System.Windows.Forms.PictureBox' is a 'type' but is used like a 'variable'

Plz help!

Answer 1

Don't you want

panel.Controls
 //^ this is an 'e'

instead of

panal.Controls?
 //^ this is an 'a'

Answer 2

In your second block the period after p.GetType == PictureBox is wrong (no period required here)... for that matter, GetType is a method/function not a Property so it needs to be p.GetType()

Answer 3

There appear to be some typos in this section (and possibly a real error).

foreach (Control p in panal.Controls)
                if (p.GetType == PictureBox.)
                   p.Location.X = 50;

The typos are

1. PictureBox is followed by a period (.)
2. GetType is missing the parens (so it isn't called).

The error is:

• You can't compare the type of p to PictureBox, you need to compare it to the type of PictureBox.

This should be:

foreach (Control p in panal.Controls)
   if (p.GetType() == typeof(PictureBox))
      p.Location = new Point(50, p.Location.Y);

Or simply:

foreach (Control p in panal.Controls)
   if (p is PictureBox)
      p.Location = new Point(50, p.Location.Y);

Answer 4

Next there might be some bugs in your for loop.

foreach (Control p in panel.Controls)
{
  if (p is PictureBox) // Use the keyword is to see if P is type of Picturebox
  {
     p.Location.X = 50;
  }
}

Answer 5

You would be better off making the picturebox a private variable of the form itself, so that you could do things with it without having to step though the panel's controls every time.

Answer 6

Try this:

foreach (Control p in panal.Controls)
{
    if (p is PictureBox)
    {
        p.Left = 50;
    }
}