tags:

views:

674

answers:

4

Hello all

I have read a few bits and bobs online about this topic but found none that work for me. What I am trying to do is create a class of a runtime Type.

I use Activator.CreateInstance which works fine for classes with constructors that contain no arguments. For those with arguments it throws an exception, is there a way around this?

I am more than happy to pass null values or empty values to the ctor so long as I can create the class itself.

Any ideas would be great

Thanks

+5  A: 

There is an overload that accepts arguments as a params object[]:

object obj = Activator.CreateInstance(typeof(StringBuilder), "abc");

Would this do? Alternative, you can use reflection to find the correct constructor:

Type[] argTypes = new Type[] {typeof(string)};
object[] argValues = new object[] {"abc"};
ConstructorInfo ctor = typeof(StringBuilder).GetConstructor(argTypes);
object obj = ctor.Invoke(argValues);
Marc Gravell
Just out of curiosity, which would be better from performance point of view: getting the list of constructors and invoking a particular constructor through reflection or directly calling Activator.CreateInstance with object[]?
Darin Dimitrov
I expect the ConstructorInfo approach. Otherwise it has to think about what values are compatible with which constructors - especially if you have passed "null" etc (which might match multiple constructors).
Marc Gravell
But you could time it ;-p Actually, if performance is an important consideration, you could case a pre-compiled LINQ Expression (since this is .NET 3.5) that represents the constructor. Let me know if you want an example of this.
Marc Gravell
A: 

Hi Chris,

Activator.CreateInstance also has a whole bunch of overloads, one you might want to check out is ( Type type, params object[] args ). Simply supply the required constructor arguments to the second parameter of this call.

Make sure you handle exceptions here though, as it's easy to pass incorrect parameters in or for something to change in the type's constructors later on that breaks it..

pezi_pink_squirrel
+1  A: 

I eventually ended up doing something like this - some of the commentors hinted towards this solution anyway.

I basically iterated through all available constructors and chose the simplest. I then created null data to pass into the ctor (for what Im using it for this approach is fine)

Part of the code looks a little like this

//If we have a ctor that requires parameters then pass null values
if (requiresParameters)
{
List<object> parameters = new List<object>();
ParameterInfo[] pInfos = constructorInfos[0].GetParameters();

foreach (ParameterInfo pi in pInfos)
{
    parameters.Add(createType(pi.ParameterType));
}

return constructorInfos[0].Invoke(parameters.ToArray());
}
Chris
A: 

I'm using this method to get around an issue I ran into, and it seems to be working exactly as I hoped. :)

object instance = Activator.CreateInstance(
    typeof(OpCode),
    BindingFlags.NonPublic | BindingFlags.Instance,
    default(Binder),
    new object[] { stringname, pop, push, operand, type, size, s1, s2, ctrl, endsjmpblk, stack },
    default(CultureInfo));
280Z28
Can that be used on any type...?
Chris