how to detect if the current time is between 15.31 - 15.45

Question

in dot net frame work 2

how to better this and easy to used i have many times

using System;
using System.Data;
using System.Configuration;
using System.Web;
using System.Web.Security;
using System.Web.UI;
using System.Web.UI.WebControls;
using System.Web.UI.WebControls.WebParts;
using System.Web.UI.HtmlControls;

public partial class _Default : System.Web.UI.Page 
{
    protected void Page_Load(object sender, EventArgs e)
    {
        string timenow = DateTime.Now.ToString("T");
        Label1.Text = DateTime.Now.ToString("T");
        Label3.Text = DateTime.Now.ToString("D");
        Label2.Text = getTimeZone(timenow);
    }

    //hh:mm:ss
    protected string getTimeZone(string time)
    {
        string[] e = time.Split(':');
        int h = Convert.ToInt16(e[0]);
        int m = Convert.ToInt16(e[1]);
        int s = Convert.ToInt16(e[2]);

        if ((h == 15) && (m >= 1) && (m <= 30) && (s <= 59))
        {
            return "15.01 - 15.30";
        }
        if ((h == 15) && (m >= 31) && (m <= 45) && (s <= 59))
        {
            return "15.31 - 15.45";
        }
        if ((h == 15) && (m >= 46) && (m == 0) && (s <= 59))
        {
            return "15.31 - 15.45";
        }

        return time;
    }
}

Answer 1

Why you are using string instead of DateTime directly, you can use DateTime.TimeofDay

Answer 2

Well, I'd take getTimeZone out of the page class and put it in a util class for a start...

Answer 3

DateTime now = DateTime.Now;
DateTime start = new DateTime(now.Year, now.Month, now.Day, 15, 31, 0);
DateTime end = new DateTime(now.Year, now.Month, now.Day, 15, 45, 0);

if (now >= start && now <= end)
    Console.WriteLine("We have a go!");

Answer 4

You could parse the strings to DateTime objects and compare them. You also you use string.CompareTo() to compare the strings directly.

Answer 5

What about something like this:

protected void Page_Load()
{
    DateTime timenow = DateTime.Now;
    Label2.Text = getTimeZone(timenow);
}

//hh:mm:ss
protected string getTimeZone(DateTime time)
{
    if (time.Hour == 15 && time.Minute >= 1 && time.Minute <= 30)
        return "15.01 - 15.30";
    if (time.Hour == 15 && time.Minute >= 31 && time.Minute <= 45)
        return "15.31 - 15.45";
    return "";
}

Answer 6

protected void Page_Load(object sender, EventArgs e)
{
    DateTime now = DateTime.Now;

    Label1.Text = now.ToString("T");
    Label3.Text = now.ToString("D");

    if (now.Hour == 15 && now.Minute >= 1 && now.Minute <= 30)
        Label2.Text = "15.01 - 15.30";
    else if (now.Hour == 15 && now.Minute >= 31 && now.Minute <= 45)
        Label2.Text = "15.31 - 15.45";
    else
        Label2.Text = now.ToString("T");
}

Answer 7

This would work if same pattern for all hours:

protected void Page_Load()
{
    DateTime timenow = DateTime.Now;
    Label1.Text = timenow.ToString("T");        
    Label3.Text = timenow.ToString("D");        
    Label2.Text = getTimeZone(timenow);         
}

//hh:mm:ss
protected string getTimeZone(DateTime time)
{
    if (time.Minute >= 1 && time.Minute <= 30)
        return String.Format("{0:00}.01 - {0:00}.30", time.Hour);
    if (time.Minute >= 31 && time.Minute <= 45)
        return String.Format("{0:00}.31 - {0:00}.45", time.Hour);
    if (time.Minute >= 46)
        return String.Format("{0:00}.46 - {1:00}.00", time.Hour, (time.Hour < 23) ?  time.Hour+1 : 0);
    if (time.Minute == 00)
        return String.Format("{0:00}.46 - {1:00}.00", (time.Hour > 0) ? time.Hour-1 : 23, time.Hour);
    return "";
}