tags:

views:

2322

answers:

6

I often run into the problem that I have one stream full of data and want to write everything of it into another stream.

All code-examples out there use a buffer in form of a byte-array.

Is there a more elegant way to this?

If not, what's the ideal size of the buffer. Which factors make up this value?

+5  A: 

Regarding the ideal buffer size:

"When using the Read method, it is more efficient to use a buffer that is the same size as the internal buffer of the stream, where the internal buffer is set to your desired block size, and to always read less than the block size. If the size of the internal buffer was unspecified when the stream was constructed, its default size is 4 kilobytes (4096 bytes)."

Any stream-reading process will use Read(char buffer[], int index, count), which is the method this quote refers to.

http://msdn.microsoft.com/en-us/library/9kstw824.aspx (Under "Remarks").

Chris
+1  A: 

http://stackoverflow.com/questions/129171/read-data-in-filestream-into-a-generic-stream

will probably have some directions to go in

tim_yates
+1  A: 

I'm not sure if you can directly pipe one stream to another in .NET, but here's a method to do it with an intermediate byte buffer. The size of the buffer is arbitrary. The most efficient size will depend mostly on how much data you're transferring.

static void CopyStream(Stream input, Stream output){
    byte[] buffer = new byte[0x1000];
    int read;
    while ((read = input.Read(buffer, 0, buffer.Length)) > 0) 
        output.Write(buffer, 0, read);
}
Bill the Lizard
You could implement this as an extension method in C# 3.0, and have it as something like static void CopyTo(this Stream input, Stream output)...
Roger Lipscombe
A: 

I'm not aware of a more elegant way, than using a buffer.

But the size of a buffer can make a difference. Remember the issues about Vista's File Copy? It's reason was (basically) changing the buffer size. The changes are explained in this blogpost. You can learn the main factors from that post. However, this only applies for file copying. In applications probably you do a lot of memory copies, so in that case, the 4KB could be the best buffer size, as recommended by the .NET documentation.

KovBal
+3  A: 

In .net 4.0 we finally got a Stream.CopyTo method! yay!

Thomas Danecker
+1  A: 

BufferedStream.CopyTo(Stream)

Leonid