ansaurus

Question

Why can't javascript find and replace strings containing spaces in the url?

Answer 1

+1 A:

You could generate a URL on the server side without the nom parameter instead of doing it in client-side JavaScript.

E.g., on the server side, lets say you received the request with nom & pays parameter; you could generate a link from server side code that excludes the pays parameter.

Isn't that straightforward to do? Let me know if I have misunderstood the question.

EDIT :

<a href="photos.php?pays="<%=variableForCountry%>" ...>link</a>

This is how it could be done in ASP. Sorry, I have not used PHP.

shahkalpesh 2009-08-21 22:01:07

I recommend this approach, too. I know the question is about regexes, but generating strings from scratch is much, *much* simpler than munging existing ones.

Alan Moore 2009-08-22 15:54:50

Answer 2

+6 A:

In regular expression the plus sign (+) has special meaning - it means to repeat the previous item once or more times.

You'll need to escape the plus sign in order for it to represent the literal plus character:

criterionText = criterionText.replace(/\+/g, '\\+');

J-P 2009-08-21 22:04:57

This is exactly what I was going to suggest, though I couldn't for the life of me remember the regex syntax in replace.

Joel Potter 2009-08-21 22:06:49

Similarily to Borgar's answer (http://stackoverflow.com/questions/1314382/why-cant-javascript-find-and-replace-strings-containing-spaces-in-the-url/1314880#1314880), this doesn't seem to work in my situation

Shawn 2009-08-24 13:52:31

Answer 3

+2 A:

You have your script quite backwards actually. You're calling removeCriterion with the value for the field, but the regex is looking for '?' + criterionText, which will only match on the key for the key/value pair.

LorenVS 2009-08-21 22:05:30

criterionText holds both the key and the value, for example: "nom=Shawn+Freyssonnet-Inder"

Shawn 2009-08-24 13:51:15

Answer 4

+2 A:

Add a regular expression escape function:

RegExp.escape = function ( s ) {
  return s.replace(/([.*+?^${}()|[\]\/\\])/g, '\\$1');
};

When building regular expressions from strings, you should escape the strings like this:

function removeCriterion(criterionText) {
    var getData = new RegExp("&" + RegExp.escape(criterionText) + "|\\?" +
                                   RegExp.escape(criterionText) + "$|" + 
                                   RegExp.escape(criterionText) + "&", "gi");
    window.location = window.location.toString().replace(getData,"");
}

Regular expression operators, such as plus, should now stop causing trouble.

Borgar 2009-08-22 01:41:43

This particular solution doesn't seem to work in my case

Shawn 2009-08-24 13:50:11

Ok it works now, I had to use javascript to simulate the php function urlencode so that it could find the string in the url. (I didn't know that $_GET automatically urldecode's...) Thank you very much for helping me solve this 2 week long problem :p

Shawn 2009-08-24 14:32:33

ansaurus

tags:

views:

answers:

Why can't javascript find and replace strings containing spaces in the url?

related questions