ansaurus

Question

Answer 1

+5 A:

JSLint found the following problems:

Error:  

Problem at line 10 character 17: ['route_id'] is better written in dot
notation.

routeCount[i]["route_id"] = routeData[i]["id"];

Problem at line 10 character 44: ['id'] is better written in dot
notation.

routeCount[i]["route_id"] = routeData[i]["id"];

Problem at line 11 character 29: ['owned'] is better written in dot
notation.

trackColor = routeData[i]["owned"] ? "#555" : "#888";

Problem at line 13 character 21: ['route_id'] is better written in dot
notation.

if(trainData[j]["route_id"] == i) {

Problem at line 14 character 1: 'new' should not be used as a
statement.

new Dialog().showMessage("test", j+":route match on "+i);

Problem at line 19 character 16: 'new' should not be used as a
statement.

if(train[0]) { new Dialog().showMessage("train",
i+":train="+train.toSource()...

Problem at line 20 character 33: ['c1_y'] is better written in dot
notation.

drawTrack(parseInt(routeData[i]["c1_y"]),

Problem at line 20 character 11: Missing radix parameter.

drawTrack(parseInt(routeData[i]["c1_y"]),

Problem at line 21 character 72: ['c1_x'] is better written in dot
notation.

parseInt(routeData[i]["c1_x"]),

Problem at line 21 character 50: Missing radix parameter.

parseInt(routeData[i]["c1_x"]),

Problem at line 22 character 72: ['c2_y'] is better written in dot
notation.

parseInt(routeData[i]["c2_y"]),

Problem at line 22 character 50: Missing radix parameter.

parseInt(routeData[i]["c2_y"]),

Problem at line 23 character 72: ['c2_x'] is better written in dot
notation.

parseInt(routeData[i]["c2_x"]),

Problem at line 23 character 50: Missing radix parameter.

parseInt(routeData[i]["c2_x"]),

Implied global: Dialog 14,19, drawTrack 20

George Stocker 2009-09-08 18:47:21

Heh... Syntax highlighter does weird stuff to JSLint output...

Shog9 2009-09-08 18:48:58

JSLint huh? Looks like a lifesaver.

ChaosPandion 2009-09-08 18:50:27

Yea; I should probably switch those to <pre> tags.

George Stocker 2009-09-08 18:50:28

Tried to add <pre> tags, looked fine in preview but really got botched on submission.

tj111 2009-09-08 18:51:25

Yea; saw that. Thanks though.

George Stocker 2009-09-08 18:51:56

Yeah... but how do you know half of these errors weren't caused by SO's worthless Javascript-powered syntax highlighter? That thing has messed up my snippets so many times.

Josh Stodola 2009-09-08 18:53:00

@Josh Stodola : I'm sure the world would love you if you could write a better one for us? Until there's a better one, this is what the SO team has got.

George Stocker 2009-09-08 18:56:54

@Josh Stodola — Funny, I've usually found the JS syntax highlighting to be more reasonable in edge cases than the server-side markdown engine its emulating.

Ben Blank 2009-09-08 19:30:55

Answer 2

A:

Update: Hmm, I like the recommendation to run jslint...

DigitalRoss 2009-09-08 18:52:46

Answer 3

+2 A:

runs fine for me if I comment out the call to drawTrack

JasonWoof 2009-09-08 19:06:14

Good point! When I commented out drawTrack, it ran fine for me as well. It seems my problem is somewhere in drawTrack. Thanks!

Chris Barnhill 2009-09-08 20:30:37

Well, the problem actually starts in this code. When I call 'train[trainCount] = trainData[j];' it is not copying trainData[j].goods which is an array nested in trainData. I think this is breaking drawTrack. Does anyone have any ideas on how to get js to copy all nested levels of the array? Thanks.

Chris Barnhill 2009-09-08 21:47:36

You should either edit your question to update it with this new question, or ask a new question with a link to this one. The former method is preferable.

George Stocker 2009-09-08 22:41:47

Thanks. Actually, it looks like the copy is working fine.

Chris Barnhill 2009-09-09 00:27:05

Answer 4

+1 A:

My fresh set of eyes see two for loops, which you say are running infinitely.

for(var i = 0; i < routeData.length; i++)

for(var j = 0; j < trainData.length; j++)

Let's assume the first loop is infinite. If that's the case i < routeData.length is always true. I can only think of two ways that would be possible.

i is decremented somewhere in the body of the loop, so that its value doesn't increase to reach routeData.length. But I don't see that happening, and I think that would be easy to spot.
routeData.length is increasing, so that i never catches up. It's possible that the drawTrack function could be adding elements to routeData, increasing its length.

The problem could also be in the second loop (or both); the same reasoning applies.

I think ultimately you're going to find a problem in the drawTrack function. Either it's appending to one of the arrays or it contains its own infinite loop.

Patrick McElhaney 2009-09-09 12:42:14

Patrick, you are correct. My problem was in drawTrack. Thanks for the help.

Chris Barnhill 2009-09-15 01:27:27

ansaurus

tags:

views:

answers:

Please help me debug this javascript

related questions