for ( ; ; ) or while ( true ) - Which is the Correct C# Infinite Loop?

Question

Back in my C/C++ days, coding an "infinite loop" as

while ( true )

felt more natural and seemed more obvious to me as opposed to

for ( ; ; )

An encounter with PC-lint in the late 1980's and subsequent best practices discussions broke me of this habit. I have since coded the loops using the for control statement. Today, for the first time in a long while, and perhaps my first need for an infinite loop as a C# developer, I am facing the same situation. Is one of them correct and the other not?

Answer 1

I think while (true) is a bit more readable.

Answer 2

I think that this may be easier to read and is definitely the standard for use in C#:

while(true)
{
   //Do My Loop Stuff
}

Answer 3

while(true)
{

}

Is always what I've used and what I've seen others use for a loop that has to be broken manually.

Answer 4

In those situations where I needed a true infinite loop, I've always used

while(true) {...}

It seems to express intent better than an empty for statement.

Answer 5

It should be while(true) not while(1), so while(1) is incorrect in C#, yes ;)

Answer 6

In terms of code readability while(true) in whatever language I feel makes more sense. In terms of how the computer sees it there really shouldn't be any difference in today's society of very efficient compilers and interpreters.

If there is any performance difference to be had I'm sure the translation to MSIL will optimise away. You could check that if you really wanted to.

Answer 7

the only reason I'd say for(;;) is due the CodeDOM limitations (While loops can't be declared using codedom and for loops are seen as the more general form as an iteration loop).

this is a pretty loose reason to choose this other than the fact that the for loop implementation can be used both for normal code and codedom generated code. ie can be more standard.

as a note, you can use code snippets to create a while loop, but the whole loop would need to be a snippet...

Answer 8

To rehash a couple of old jokes:

1. Don't use "for (;;) {}" — it makes the statement cry.
2. Unless, of course, you "#define EVER ;;".

Answer 9

The C# compiler will transform

for(; ; )
{
}

into

while (true)
{
}

The IL for both is the same. Most people find while(true) to be easier to read and understand. for(;;) is rather cryptic.

Edit

I messed a little more with Reflector and I compiled both loop with the "Optimize Code" on in Visual Studio.

Both loop compile into (with Reflector)

Label_0000:
    goto Label_0000;

Raptors should attack soon.

Answer 10

Gasp, what about

while (!false)
{

}

OR as jsight pointed out, you may want to be doubly sure

while (!false && true)
{
}

Before people yell at me, its all the same IL code, I checked :)

Answer 11

Personally, I have always preferred for(;;) precisely because it has no condition (as opposed to while (true) which has an always-true one). However, this is really a very minor style point, which I don't feel is worth arguing about either way. I've yet to see a C# style guideline that mandated or forbade either approach.

Answer 12

I personally prefer the for (;;) idiom (coming from a C/C++ point of view). While I agree that the while (true) is more readable in a sense (and it's what I used way back when even in C/C++), I've turned to using the for idiom because:

• it stands out

I think the fact that a loop doesn't terminate (in a normal fashion) is worth 'calling out', and I think that the for (;;) does this a bit more.

Answer 13

Alternatively one could say having an infinite loop is normally bad practice anyway, since it needs an exit condition unless the app really runs forever. However, if this is for a cruise missile I will accept an explicit exit condition might not be required.

Though I do like this one:

for (float f = 16777216f; f < 16777217f; f++) { }

Answer 14

I know in the C++ world Stroustrup advocates for(;;) in TC++PL, but I don't recall why.

Answer 15

Any expression that always returns true should be OK for while loop.

Example:

1==1 //Just an example for the text stated before 
true

Answer 16

If you want to go old-school. Goto is still supported in C#

STARTOVER:  
    //Do something
    goto STARTOVER;

For a truly infinite loop, this is the go-to command. =)

Answer 17

I prefer slightly more "literate" code. I'm much more likely to do something like this in practice:

bool shouldContinue = true;
while (shouldContinue)
{
    // ...

    shouldContinue = CheckSomething();
}

Answer 18

The original K&R book for C, from which C# can trace its ancestry, recommended

for (;;) ...

for infinite loops. It's unambiguous, easy to read, and has a long and noble history behind it.

Answer 19

Who cares. It's not like if you stumble across a for(;;) in source control you're going to replace it with a while(true). Arguing this is like arguing brace placement.

Answer 20

Even i also say below one is better :)

while(true)
{

}

Answer 21

while(1) { }

Answer 22

If you're code-golfing, I would suggest for(;;). Beyond that, while(true) has the same meaning and seems more intuitive. At any rate, most coders will likely understand both variations, so it doesn't really matter. Use what's most comfortable.