ansaurus

Question

Answer 1

A:

   $tag = mysql_real_escape_string($_POST['tag']);
    $query = 'UPDATE tags SET count = count+1 WHERE tag = "'.$tag.'"';
    mysql_query($query,$dbc);
    if( !mysql_affected_rows() ) {
      $query = 'INSERT INTO tags (tag,count) VALUES("'.$tag.'",1)';
      if (!mysql_query($query,$dbc))
      {
      die('Error: ' . mysql_error());
      }
    echo "1 record added";
    }

    mysql_close($dbc);

Missing a semicolon on the last line

PS: Giving us the parse error makes finding the answer much easier.

Chacha102 2009-09-21 21:46:50

I get this error now Parse error: syntax error, unexpected $end in

2009-09-21 21:49:26

Remove the semicolon at the end of the 2nd if statement. (I fixed my code)

Chacha102 2009-09-21 21:50:24

And You forgot to close the first if statement

Chacha102 2009-09-21 21:51:11

it kind of works now, but it wont update my database now wierd.

2009-09-21 21:53:52

The if statement with the mysql_query() needs to be checking for a false, right now it checks for a true, which means that the query worked.

Chacha102 2009-09-21 21:54:57

how can i change it?

2009-09-21 21:56:08

I just fixed it in my code.

Chacha102 2009-09-21 21:56:41

No it still wont work:(

2009-09-21 21:58:45

Well, if it isn't updating you actual mysql database, you might have a mysql error or something, which I can't really fix.

Chacha102 2009-09-21 21:59:38

SHould I post the whole script?

2009-09-21 22:00:10

Well, first try and debug it. Put echos in all of the if statements to see exactly what is happening. (What is the query, are there any mysqsl_error()s, etc)

Chacha102 2009-09-21 22:04:02

No more mysql errors the form is displayed I did something wrong though?

2009-09-21 22:05:32

Yes, something is wrong if it isn't updating. You might want to open up another question/answer about that, since it is a separate problem. In that you might want to post the full code too.

Chacha102 2009-09-21 22:08:31

okay thanks for all the help. and thanks every one for trying.

2009-09-21 22:09:47

Use 'single quotes', not "double-quotes" for SQL string literal delimiters. Double-quotes is MySQL-only that means something quite different in ANSI SQL and will fail on most other databases, as well as on MySQL itself under various configurations. Single quotes work everywhere.

bobince 2009-09-22 00:05:55

Answer 2

A:

$tag = mysql_real_escape_string($_POST['tag']);
$query = 'UPDATE tags SET count = count + 1 WHERE tag = "'.$tag.'"';
mysql_query($query,$dbc);
if( !mysql_affected_rows() ) {
  $query = 'INSERT INTO tags (tag,count) VALUES("'.$tag.'",1)';
  if (!mysql_query($query,$dbc));
  {
  die('Error: ' . mysql_error());
  }
echo "1 record added";

mysql_close($dbc);

jusunlee 2009-09-21 21:52:46

who gave me a negative point? i added quotations so that mysql will accept the queries... completely unacceptable.

jusunlee 2009-09-21 21:54:47

The reason Negative points are anyomous is just that. I gave you a negative because right now the first if statement won't worth, and the second if statement won't work.

Chacha102 2009-09-21 21:56:04

wow youre answer won't work because you don't have quotations for the string tag. Good job mate promoting your answer that doesn't work.

jusunlee 2009-09-21 21:58:32

Look again.

Chacha102 2009-09-21 21:58:56

way to edit your answer to "reflect" what i did. thanks a bunch chacha.

jusunlee 2009-09-21 21:59:16

wow this system is ridiculous... you just gave me a negative point and then proceeded to copy my answer to your post. great job little man.

jusunlee 2009-09-21 22:00:19

I'm just trying to help the guy. That is the goal of the forums. It isn't a competition, it is trying to be helpful. Combining ideas from multiple answers is helpful, and creates the most correct answer.

Chacha102 2009-09-21 22:00:37

dude you voted my answer down WHICH was CORRECT unlike YOURS. way to HELP. right.

jusunlee 2009-09-21 22:01:19

IT ISN'T CORRECT. BOTH OF YOU IF STATEMENTS WON'T WORK. Fix it, and I'll remove the downvote. Very simple.

Chacha102 2009-09-21 22:02:05

This is complete abuse of the system. You just voted my answer down and proceeded to copy mine to correct your original answer.

jusunlee 2009-09-21 22:02:14

You know what, go complain to Meta. See how many people don't care. meta.stackoverflow.com

Chacha102 2009-09-21 22:03:00

btw your insert still wont work.. you need the double quotes to indicate string.

jusunlee 2009-09-21 22:04:35

You almost found them all :-) Just missing the } for the first **if** statement...

jeroen 2009-09-21 22:13:35

Answer 3

+1 A:

Some problems: Missing }, ; after if, missing ;, dying on success (second query), $tag not in quotes:

$tag = mysql_real_escape_string($_POST['tag']);
$query = "UPDATE tags SET count = count+1 WHERE tag = '".$tag."'";
mysql_query($query,$dbc);
if( !mysql_affected_rows() ) {
   $query = "INSERT INTO tags (tag,count) VALUES('".$tag."',1)";
   if ( !mysql_query($query,$dbc) )
   {
       die('Error: ' . mysql_error());
   }
   echo "1 record added";
}

mysql_close($dbc);

That seems about it, at least if $dbc is a valid connection...

jeroen 2009-09-21 22:04:29

You mean quotes and not parenthesis.

Gumbo 2009-09-22 04:22:07

You're right...

jeroen 2009-09-22 13:37:31

Answer 4

A:

Actually the problem with your script like single quotes not ended properly.

Here is corrected code

<?php

$tag = mysql_real_escape_string($_POST['tag']);

    $query = "UPDATE tags SET count = count+1 WHERE tag = '".$tag."'";

    mysql_query($query,$dbc);

    if( !mysql_affected_rows() ) {

      $query = "INSERT INTO tags (tag,count) VALUES('".$tag.",1)";

      if (mysql_query($query,$dbc))

      {

      die('Error: ' . mysql_error());

      }

    echo "1 record added";


    mysql_close($dbc)

?>

santosh 2009-09-22 15:01:09

ansaurus

tags:

views:

answers:

Mysql and PHP Problem?

related questions