tags:

views:

2501

answers:

6

Hey guys, I'm trying to build an instruction pipeline simulator and I'm having a lot of trouble getting started. What I need to do is read binary from stdin, and then store it in memory somehow while I manipulate the data. I need to read in chunks of exactly 32 bits one after the other.

How do I read in chunks of exactly 32 bits at a time? Secondly, how do I store it for manipulation later?

Here's what I've got so far, but examining the binary chunks I read further, it just doesn't look right, I don't think I'm reading exactly 32 bits like I need.

char buffer[4] = {0,0,0,0}; //initialize to 0
unsigned long c = 0;
int bytesize = 4; //read in 32 bits
while( fgets(buffer, bytesize, stdin) ){
  memcpy( &c, buffer, bytesize); //copy the data to a more usable structure for bit manipulation later
  //more stuff
  buffer[0]=0; buffer[1]=0; buffer[2]=0; buffer[3]=0; //set to zero before next loop
}
fclose(stdin);

How do I read in 32 bits at a time (they are all 1/0, no \newlines etc), and what do I store it in, is char[] okay?

EDIT: I'm able to read the binary in but none of the answers produce the bits in the correct order - they are all mangled up, I suspect endianness and problems reading and moving 8 bits around ( 1 char) at a time - this needs to work on windows and C ... ?

+2  A: 

fread() suits best for reading binary data.

Yes, char array is OK, if you are planning to process them bytewise.

elder_george
This is not the answer. `stdin` is a buffered input stream, and `fread()` will read buffered data, and on Windows it will be reading in text mode and convert `\r\n` to a single character, which will be bad for binary data.
Chris Lutz
A: 

I don't know what OS you are running, but you typically cannot "open stdin in binary". You can try things like

int fd = fdreopen (fileno (stdin), outfname, O_RDONLY | OPEN_O_BINARY);

to try to force it. Then use

uint32_t opcode;
read(fd, &opcode, sizeof (opcode));

But I have no actually tried it myself. :)

Paul Hsieh
You don't have to do the fdreopen(). stdin is always open - see my answer.
Bob Murphy
WTF?? I know its open, that's the only kind of file you can *FEED* into fdreopen. But it has the wrong *MODE*. stdin is opened as a *TEXT* file. The guy wants to read raw binary data, and text isn't going to cut it.
Paul Hsieh
A: 

fgets() is all wrong here. It's aimed at human-readable ASCII text terminated by end-of-line characters, not binary data, and won't get you what you need.

I recently did exactly what you want using the read() call. Unless your program has explicitly closed stdin, for the first argument (the file descriptor), you can use a constant value of 0 for stdin. Or, if you're on a POSIX system (Linux, Mac OS X, or some other modern variant of Unix), you can use STDIN_FILENO.

Bob Murphy
This won't work for non-POSIX systems, of course, which defeats the purpose, because on POSIX systems there is no difference between binary reading and text reading for filehandles.
Chris Lutz
I'm not sure why you got voted down. read() is the more appropriate call.
Catskul
+3  A: 

What you need is freopen(). From the manpage:

If filename is a null pointer, the freopen() function shall attempt to change the mode of the stream to that specified by mode, as if the name of the file currently associated with the stream had been used. In this case, the file descriptor associated with the stream need not be closed if the call to freopen() succeeds. It is implementation-defined which changes of mode are permitted (if any), and under what circumstances.

Basically, the best you can really do is this:

freopen(NULL, "rb", stdin);

This will reopen stdin to be the same input stream, but in binary mode. In the normal mode, reading from stdin on Windows will convert \r\n (Windows newline) to the single character ASCII 10. Using the "rb" mode disables this conversion so that you can properly read in binary data.

freopen() returns a filehandle, but it's the previous value (before we put it in binary mode), so don't use it for anything. After that, use fread() as has been mentioned.

As to your concerns, however, you may not be reading in "32 bits" but if you use fread() you will be reading in 4 chars (which is the best you can do in C - char is guaranteed to be at least 8 bits but some historical and embedded platforms have 16 bit chars (some even have 18 or worse)). If you use fgets() you will never read in 4 bytes. You will read in at least 3 (depending on whether any of them are newlines), and the 4th byte will be '\0' because C strings are nul-terminated and fgets() nul-terminates what it reads (like a good function). Obviously, this is not what you want, so you should use fread().

Chris Lutz
There's no need to even try to assign the return value of `freopen` to `stdin` - `freopen` either returns `NULL` or the previous value of `stdin` (it changes the pointed-to `FILE` but doesn't change the `FILE *` value itself)
caf
Ah. I didn't realized it returned the old value. Edited to fix.
Chris Lutz
+1  A: 

Consider using SET_BINARY_MODE macro and setmode:

#ifdef _WIN32
# include <io.h>
# include <fcntl.h>
# define SET_BINARY_MODE(handle) setmode(handle, O_BINARY)
#else
# define SET_BINARY_MODE(handle) ((void)0)
#endif

More details about SET_BINARY_MODE macro here: "Handling binary files via standard I/O"

More details about setmode here: "_setmode"

Adrian
A: 

I had it right the first time, except, I needed ntohl ... http://stackoverflow.com/questions/1614399/c-endian-conversion-bit-by-bit/1615275#1615275

rlb.usa