views:

35

answers:

3

HI, I've got:

<script language="javascript" type="text/javascript">
$(document).ready(function() {
 $("#thumbs a").click( function() {
      var BGswitch = $(this).attr("href");
      $("#target").css("background-image", "url(BGswitch)");
      return false;
      });
});
</script>

And it's not quite working--when I look at the code, the variable itself (BGswitch) is being put in the background-image slot instead of the value of the variable which is supposed to be the href.... Anyone? Some kind of syntax error or something?

THANK YOU!

+1  A: 

"url(BGswitch)" is literally the string "url(BGswitch)". You need to build the string by concatenation:

"url(" + BGswitch + ")"
deceze
thanks very much!
McFly88
+1  A: 

Shouldn't it be

$("#target").css("background-image", "url("+BGswitch+")");
Sergej Andrejev
Thank you very much!
McFly88
+1  A: 
$("#target").attr("background-image", "url(" + BGswitch + ")");

Check this

Shadi Almosri
Thank you very much!
McFly88
my pleasure! :)
Shadi Almosri