program to find the sum of digits

Question

I can't figure out the problem in this:

#include<stdio.h>
int main()
{
    int a,b,count ;
    count =0;
    printf("enter the value for a ");
    scanf("%d ",&a);
    while(a>0)
    {
        b=a%10;
        count=b+count;
        a=a/10; 

        printf ("hence the simplified result is %d",count);
    }
    return 0;
}

Answer 1

I think the printf statement should be outside the loop.

Answer 2

One issue is you print the count with every loop, rather than than after the loop.

Not an issue, but C has arithmetic assignment (aka compound assignment) operators that can be more readable. For example, a /= 10 is equivalent to a = a/10.

Answer 3

You do not terminate your printf() with a "\n". The output stream (stdout) is, usually, line buffered. That means that incomplete lines need not be printed unless you force them with fflush(). But there's no need for that.

Simply add a "\n" to your printf()

        printf("hence the simplified result is %d\n", count);

Answer 4

Move the printf out side the loop. That will fix it.

Answer 5

Try the following:

#include<stdio.h>
int main()
{
    int a,b,count ;
    count =0;
    printf("enter the value for a ");
    scanf("%d",&a);
    while(a>0)
    {
        b=a%10;
        count=b+count;
        a=a/10; 
    } 
    printf ("hence the simplified result is %d",count);
    return 0;
}

Answer 6

There's a silent killer in your code:

scanf("%d ",&a);

The extra space in your scanf will make entering numbers harder: this will match 12<space>, but not 12. Replace the "%d " with "%d".