views:

160

answers:

2

I'm attempting upload multiple files in ASP.NET MVC and I have this simple foreach loop in my controller

    foreach (HttpPostedFileBase f in Request.Files)
    {
        if (f.ContentLength > 0)
            FileUpload(f);
    }

The previous code generates this error:

    Unable to cast object of type 'System.String' to type 'System.Web.HttpPostedFile'.

What I don't understand is why Request.Files[1] returns an HttpPostedFileBase but when it's iterated over, it returns strings (presumably the file names).

Note: I know this can be solved with a for loop. Also, I tried using HttpPostedFile, with the same error.

UPDATE

A: 

You might try iterating the strings and casting them to HttpPostedFile instead, like this:

foreach (string file in Request.Files)
    {
        HttpPostedFile hFile = Request.Files[file] as HttpPostedFile;
        if (hFile.ContentLength > 0)
            FileUpload(hFile);
    }
Joe Barone
+3  A: 

The enumerator on the HttpFileCollection returns the keys (names) of the files, not the HttpPostedFile objects. Once you get the key, use the Item ([]) property with the key (filename) to get the HttpPostedFile object.

foreach (string fileName in Request.Files)
{
    HttpPostedFile file = Request.Files[fileName];

    ...
}
tvanfosson
Is there a way to have it return an HttpPostedFile instead?
Baddie
Not that I know of. It derives from NameObjectCollectionBase and the enumerator for that class iterates over the keys.
tvanfosson