ObservableCollection<T> does not update ListBox

Question

Hi

I've set the ItemSource of a ListBox to a ObservableCollection collection, and my Employee class implements INotifyPropertyChanged.

On the Employee I've bound several properties, one of them a Color property, and I've ensured that it invokes the PropertyChanged event when it's changed. I've also checked with the debugger that the PropertyChanged invoke is called.

However, when databound the Background of the ListBoxItem in the bound ListBox does never update, which is extremely fustrating.

Setting the ItemSource to null, and resetting it after works, but it's not how we're meant to utilize the Observer Pattern.

The XAML used:

<Style TargetType="{x:Type ListBoxItem}">
<Style.Resources>
    <SolidColorBrush x:Key="{x:Static SystemColors.ControlBrushKey}"
        Color="{x:Static SystemColors.HighlightColor}" />
</Style.Resources>
<Setter Property="Foreground" Value="White" />
<Setter Property="Background" Value="{Binding Path=Color, Converter={StaticResource ColorConverter}}" />
<Setter Property="Content" Value="{Binding Path=Name}" />
<Setter Property="Height" Value="25" />
<Setter Property="Margin" Value="0,1,0,1" />
<EventSetter Event="MouseDoubleClick" Handler="HelperList_MouseDoubleClick" />

<ListBox x:Name="helperList" Grid.Column="0" Grid.Row="1" 
     Margin="5,2,0,5" VerticalAlignment="Stretch" HorizontalAlignment="Stretch"
     ScrollViewer.VerticalScrollBarVisibility="Visible"

     SelectionChanged="HelperList_SelectionChanged">

More Code in response to first reply:

public class Employee : Person
{
    private EmployeeColor color = new EmployeeColor();
    public EmployeeColor Color
    {
        get { return this.color; }
        set
        {
            if(!this.color.Equals(value))
                OnPropertyChanged("Color");

            this.color = value;
        }
    }
}

var employees = new ObservableCollection<Employee>();
//... fill out data here    
helperList.ItemsSource = employees;

Answer 1

Problem solved.

OnPropertyChanged was called BEFORE the actual value of the property was set, so the UI was updating accordingly to the old value.

Solution: Call OnPropertyChanged after setting the property value.