ansaurus

Question

JS: Hiding DIV based on another DIVs content

Answer 1

A:

You need to set the style.display property to none.

Bryan Kyle 2009-11-20 17:07:44

Answer 2

+3 A:

You are forgetting a couple of things.

A function declaration should be like this

function functionName(args) { }
You have to hide the divs using style.display = "none"

Example:

<div id="LEGEND">abB</div>

<div id="small-a" style="display: none;">This is small-a</div> 
<div id="small-b" style="display: none;">This is small-b</div> 
<div id="big-a" style="display: none;">This is big-a</div> 
<div id="big-b" style="display: none;">This is big-b</div>

<script>
function showElement(id) {
    document.getElementById(id).style.display = "block";
}

window.onload = function ShowHide() {
    var legend = document.getElementById("LEGEND").innerHTML;

    if(legend.indexOf("a") != -1) showElement("small-a");
    if(legend.indexOf("b") != -1) showElement("small-b");
    if(legend.indexOf("A") != -1) showElement("big-a");
    if(legend.indexOf("B") != -1) showElement("big-b");
}
</script>

Matthias Vance 2009-11-20 17:10:43

This worked perfectly! Thanks for the fixes, well formatted answer too.

CWCWCW 2009-11-20 19:56:29

Answer 3

+1 A:

First, try making sure the window.onload is being called:

window.addEventListener('load', ShowHide, false);

function ShowHide()
{...

Second, you should be looking at the InnerHTML of the element:

if (document.getElementById('LEGEND').innerHTML.match("a") == "a"){...

Third, each if statement should also contain an else (replace divName with real div names):

else {
    document.getElementById('divName').style.display = 'none'}

Hope that helps!

~md5sum~

EDIT:

Also, I'm not 100% sure on this, but I believe that the syntax:

window.onload = function ShowHide{

will completely fail. I think that the syntax should be:

window.onload = function(){

md5sum 2009-11-20 17:13:50

Answer 4

+1 A:

The problem is that your code changes the other div elements to block-level elements when div is already a block-level element. You need to set them not to display initially using CSS and then reveal them in the JavaScript.

Try this instead:

<div id="LEGEND">abAB</div>       

<div id="small-a" style="display: none;"></div>        
<div id="small-b" style="display: none;"></div>        
<div id="big-a" style="display: none;"></div>        
<div id="big-b" style="display: none;"></div>

<script type="text/javascript">
  window.onload = function() {
    if (document.getElementById('LEGEND').indexOf('a') > 0) {
      document.getElementById('small-a').style.display = 'block';
      ...
      // etc.
    }
  }
</script>

John Topley 2009-11-20 17:15:34

Answer 5

+1 A:

If me, I will do like this. you dont need to touch HTML part, everything is done in javascript.

you can extend it to CDEFGH...

and you don't need to set <div id="small-X" style="display: none;"> for each tags too. :-)

<body>
<script>

window.onload=function(){

    x=document.getElementsByTagName("div");

    //first hide everything with small- or big-

    for(i in x)
     if(/small-|big-/.test(x[i].id))
      x[i].style.display="none";

    //then turn on each tags based on LEGEND

    x= document.getElementById("LEGEND").innerHTML;
    for(i=0;i<x.length;i++)
     document.getElementById((x[i]<='Z'?'big-':'small-')+x[i].toLowerCase()).style.display='block';

}
</script>
<div id="LEGEND">aAB</div>

<div id="small-a">a</div> 
<div id="small-b">b</div> 
<div id="big-a">A</div> 
<div id="big-b">B</div>
</body>

S.Mark 2009-11-20 17:30:22

ansaurus

tags:

views:

answers:

JS: Hiding DIV based on another DIVs content

related questions