views:

648

answers:

10

I understand the benefits of StringBuilder.

But if I want to concatenate 2 strings, then I assume that it is better (faster) to do it without StringBuilder. Is this correct?

At what point (number of strings) does it become better to use StringBuilder?

+2  A: 

A single concatenation is not worth using a stringbuilder. I've typically used 5 concatenations as a rule of thumb.

Matt Wrock
+8  A: 

Not really...you should use StringBuilder if you concatenate large strings or you have many concatenations, like in a loop.

Bobby
That is wrong. You should use `StringBuilder` only if the loop or the concatenation is a performance problem to the specs.
Alex Bagnolini
-1 for incorrect generalisation. string s = "a" + "b" + "c" + "d"; uses one memory allocation for s. Look at the last (9th) overload for string.Concat. The above code basically gets compiled down to string.Concat("a", "b", "c", "d") in MSIL.
Binary Worrier
@Alex: Isn't that always the case? ;) No, seriously, I've always used StringBuilder for concatenation inside a loop...though, my loops all have more than 1k iterations... @Binary: Normally, that should be compiled to `string s = "abcd"`, at least that's the last thing I heard...though, with variables it would be, most likely, Concat.
Bobby
The fact is: it nearly ALWAYS IS NOT the case. I always used string operators `a + "hello" + "somethingelse"` and never had to worry about it. If it will become a problem, I'll use StringBuilder. But I didn't worry about it in the first place, and spent less time writing it.
Alex Bagnolini
Binary Worrier
There’s absolutely no performance benefit with large strings – *only* with many concatenations.
Konrad Rudolph
@Konrad: Are you sure there's *no* performance benefit? Every time you concatenate large strings, you're copying a large amount of data; Every time you concatenate small strings, you're only copying a small amount of data.
LukeH
@Konrad: You're most likely right, though, I thought about _really_ large strings...I could imagine that there might be a gain _somewhere_. @Alex: A simple loop (32768 iterations, okay, are a little much, but you get the picture) with adding an 'a' to a String (+=) and to a StringBuilder (.Append()) turns on my machine up with 870ms to 1ms... @Binary: Strings would become the Concat, yes. ;)
Bobby
+2  A: 

But if I want to concatinate 2 strings, then I assume that it is better (faster) to do it without StringBuilder. Is this correct?

Yes. But more importantly, it is vastly more readable to use a vanilla strings in such situations. Using it in a loop, on the other hand, makes sense and can also be as readable as concatenation.

I’d be wary of rules of thumb that cite specific numbers of concatenation as a threshold. Using it in loops (and loops only) is probably just as useful, easier to remember and makes more sense.

Konrad Rudolph
+21  A: 

I warmly suggest you to read The Sad Tragedy of Micro-Optimization Theater, by Jeff Atwood.

It treats Simple Concatenation vs. StringBuilder vs. other methods.

Now, if you want to see some numbers and graphs, follow the link ;)

Alex Bagnolini
+1 for _yes_! Time spent worrying about this is time spent not doing something that might actually matter.
Greg D
Your reading is wrong however : it doesn't matter in a lot of cases, when no looping is involved, in other cases however it can matter A LOT
Peter
I have removed the edit, because it was just wrong info in an accepted answer.
Peter
and just to show how mucht it matters, from the article you are refering to : "In most garbage collected languages, strings are immutable: when you add two strings, the contents of both are copied. As you keep adding to result in this loop, more and more memory is allocated each time. This leads directly to awful quadradic n2 performance"
Peter
I can't fully agree on that link...he's using the mechanism within a method, just comparing what's faster with _some_ concatenation and what's faster to instance. If you declare the StringBuilder outside of the loop, it clearly beats everything.
Bobby
+14  A: 

But if I want to concatinate 2 strings, then I assume that it is better (faster) to do it without StringBuilder. Is this correct?

That is indeed correct, you can find why exactly explained very well on :

http://www.yoda.arachsys.com/csharp/stringbuilder.html

Summed up : if you can concatinate strings in one go like

var result = a + " " + b  + " " + c + ..

you are better of without stringbuilder for only on copy is made (the length of the resulting string is calculated beforehand);

For structurs like

var result = a;
result  += " ";
result  += b;
result  += " ";
result  += c;
..

new objects are created each time, so there you should consider StringBuilder.

At the end the article sums up these rules of thumb :

Rules Of Thumb

So, when should you use StringBuilder, and when should you use the string concatenation operators?

  • Definitely use StringBuilder when you're concatenating in a non-trivial loop - especially if you don't know for sure (at compile time) how many iterations you'll make through the loop. For example, reading a file a character at a time, building up a string as you go using the += operator is potentially performance suicide.

  • Definitely use the concatenation operator when you can (readably) specify everything which needs to be concatenated in one statement. (If you have an array of things to concatenate, consider calling String.Concat explicitly - or String.Join if you need a delimiter.)

  • Don't be afraid to break literals up into several concatenated bits - the result will be the same. You can aid readability by breaking a long literal into several lines, for instance, with no harm to performance.

  • If you need the intermediate results of the concatenation for something other than feeding the next iteration of concatenation, StringBuilder isn't going to help you. For instance, if you build up a full name from a first name and a last name, and then add a third piece of information (the nickname, maybe) to the end, you'll only benefit from using StringBuilder if you don't need the (first name + last name) string for other purpose (as we do in the example which creates a Person object).

  • If you just have a few concatenations to do, and you really want to do them in separate statements, it doesn't really matter which way you go. Which way is more efficient will depend on the number of concatenations the sizes of string involved, and what order they're concatenated in. If you really believe that piece of code to be a performance bottleneck, profile or benchmark it both ways.

Peter
+3  A: 

System.String is an immutable object - it means that whenever you modify its content it will allocate a new string and this takes time (and memory?). Using StringBuilder you modify the actual content of the object without allocating a new one.

So use StringBuilder when you need to do many modifications on the string.

Victor Hurdugaci
+1  A: 

There's no definitive answer, only rules-of-thumb. My own personal rules go something like this:

  • If concatenating in a loop, always use a StringBuilder.
  • If the strings are large, always use a StringBuilder.
  • If the concatenation code is tidy and readable on the screen then it's probably ok.
    If it isn't, use a StringBuilder.
LukeH
+2  A: 

I don't think there's a fine line between when to use or when not to. Unless of course someone performed some extensive testings to come out with the golden conditions.

For me, I will not use StringBuilder if just concatenating 2 huge strings. If there's loop with an undeterministic count, I'm likely to, even if the loop might be small counts.

o.k.w
Indeed it would be completely wrong to ues StringBuilder to concat 2 strings, but that is nothing to do with perf. testing - that is simply using it for the wrong thing.
Marc Gravell
+2  A: 

As long as you can physically type the number of concatenations (a + b + c ...) it shouldn't make a big difference. N squared (at N = 10) is a 100X slowdown, which shouldn't be too bad.

The big problem is when you are concatenating hundreds of strings. At N=100, you get a 10000X times slowdown. Which is pretty bad.

wisty
+2  A: 

To paraphrase

Then shalt thou count to three, no more, no less. Three shall be the number thou shalt count, and the number of the counting shall be three. Four shalt thou not count, neither count thou two, excepting that thou then proceed to three. Once the number three, being the third number, be reached, then lobbest thou thy Holy Hand Grenade of Antioch

I generally use string builder for any block of code which would result in the concatenation of three or more strings.

Russell Steen
It depends : Concetanation only makes one copy : "Russell" + " " + Steen + ".", will only make one copy because it calcs the length of the string beforehand. Only when you have to split your concatenation, you should begin to think about a builder
Peter