views:

612

answers:

5

My Spider Sense warns me that using eval() to parse incoming JSON is a bad idea. I'm just wondering if JSON.parse() - which I assume is a part of JavaScript and not a browser-specific function - is more secure.

A: 

JSON is just a subset of JavaScript. But eval evaluates the full JavaScript language and not just the subset that’s JSON.

Gumbo
Right, I know that. Are you implying that JSON.parse() ONLY evaluates JSON and fails on all other incoming data? Or is it simply a wrapper for:var myObject = eval('(' + responseText + ')');??
Kevin Major
@Kevin Major: Yes, the natively implemented `JSON.parse` (directly implemented into the JavaScript engine) parses only JSON. But other non-natively implementations use do some sanity checking and then use `eval` for performance reasons.
Gumbo
+1  A: 

If you parse the JSON with eval, you're allowing the string being parsed to contain absolutely anything, so instead of just being a set of data, you could find yourself executing function calls, or whatever.

Also, JSON's parse accepts an aditional parameter, reviver, that lets you specify how to deal with certain values, such as datetimes (more info and example in the inline documentation here)

David Hedlund
+9  A: 

You are more vulnerable to attacks if using eval: JSON is a subset of Javascript and json.parse just parses JSON whereas eval would leave the door open to all JS expressions.

jldupont
+3  A: 

Not all browsers have native JSON support so there will be times where you need to use eval() to the JSON string. Use JSON parser from http://json.org as that handles everything a lot easier for you.

Eval() is an evil but against some browsers its a necessary evil but where you can avoid it, do so!!!!!

AutomatedTester
+2  A: 

All JSON.parse implementations most likely use eval()

JSON.parse is based on Douglas Crockford's http://www.json.org/json2.js, which uses eval() right there on line 469

// In the third stage we use the eval function to compile the text into a
// JavaScript structure. The '{' operator is subject to a syntactic ambiguity
// in JavaScript: it can begin a block or an object literal. We wrap the text
// in parens to eliminate the ambiguity.

j = eval('(' + text + ')');

The advantage of JSON.parse is that it verifies the argument is correct JSON syntax.

plodder
yeah, except that the line right before that verifies that it's a safe and valid string.
nickf