tags:

views:

678

answers:

7

So I understand what boxing and unboxing is. When's it come up in real-world code, or in what examples is it an issue? I can't imagine doing something like this example:

int i = 123;
object o = i;           // Boxing
int j = (int)o;  // Unboxing

...but that's almost certainly extremely oversimplified and I might have even done boxing/unboxing without knowing it before.

+7  A: 

Boxing (in my experience) usually occurs in these cases:

  • A value type is passed to a method that accepts an argument of type Object.
  • A value type is added to a non-generic collection (like an ArrayList).

Other times you can see boxing and unboxing is when you use reflection as the .NET framework's reflection API makes heavy use of Object.

Andrew Hare
We need to note: int (Int32) is a subclass of the abstract class ValueType, which is a subclass of Object.
Gabriel McAdams
I wouldn't say it's a "subclass" - it's not a *class* at all. It inherits from (or derives from) `ValueType`. The C# and CLI spec use slightly different terminology on this front, which doesn't help matters.
Jon Skeet
+19  A: 

It's much less of an issue now than it was prior to generics. Now, for example, we can use:

List<int> x = new List<int>();
x.Add(10);
int y = x[0];

No boxing or unboxing required at all.

Previously, we'd have had:

ArrayList x = new ArrayList();
x.Add(10); // Boxing
int y = (int) x[0]; // Unboxing

That was my most common experience of boxing and unboxing, at least.

Without generics getting involved, I think I'd probably say that reflection is the most common cause of boxing in the projects I've worked on. The reflection APIs always use "object" for things like the return value for a method - because they have no other way of knowing what to use.

Another cause which could catch you out if you're not aware of it is if you use a value type value which implements an interface, and pass that value to another method which has the interface type as its parameter. Again, generics make this less of a problem, but it can be a nasty surprise if you're not aware of it.

Jon Skeet
"I think I'd probably say that reflection is the most common cause of boxing in the projects I've worked on" -- this, of course, will depend heavily on the kind of projects. For example, if you work with WPF or Silverlight, boxing will occur *all the time* as you work with value converters (IValueConverter takes and returns object), dependency properties (DependencyObject.GetValue and SetValue return and take object), etc.
itowlson
+1 For interface implemented on a value type - that is a sneaky one :)
Andrew Hare
@itowlson: Those are great examples - mind if I add them to my answer?
Jon Skeet
Is it safe to say that boxing is "casting something to an object" and unboxing is "casting it back to its type"?
JYelton
@JYelton: I think that's a bit to general *and* too specific. Firstly, it only applies to value types. Secondly, it happens whenever you convert a value type value to a reference type value: an interface, `Object`, `ValueType` or `Enum`.
Jon Skeet
Thanks, I'm trying to understand the concept and this question thread helped. :)
JYelton
+1  A: 

Boxing and unboxing is really moving from value type to reference type. So, think of it as moving from the stack to the heap and back again.

There certainly are cases where this is relevant. The inclusion of generics in the 2.0 framework cut a lot of common boxing cases out of practice.

marcc
A: 

Since the advent of strongly-typed lists and dictionaries using generics with C# 2.0 (Visual Studio 2005), I think the importance of keeping boxing/unboxing in mind have been amazingly minimized. Add to that nullable types (int?, etc.) and using the null coalescing operator (??) and it really shouldn't be much of a concern at all and would likely not see it in any code that's not 1.1 Framework or earlier.

Jesse C. Slicer
No, in generics there's a lot more boxing going on than most people would expect. C# will emit .box when you check unconstraint Ts against null.
Robert Giesecke
I agree with that - but that is the developer's decision to do when implementing a generic method/class. From a framework perspective, the generic collections allow the consumer to forego the boxing/unboxing scenario. When I code the scenario you describe, my unconstrained T would be compared against default(T), not null. If I *really* need a check against null, T better be constrained to a reference type.
Jesse C. Slicer
"in any code that's not 1.1 Framework or earlier" - what about a simple string.Format("My number is {0}", 123)?
Alex
I give you that will indeed box (but not unbox), but if you are performing such an operation in a program's hotspot where boxing and/or unboxing have an obvious adverse effect on performance, then I daresay your system organization or algorithm is faulty.
Jesse C. Slicer
+4  A: 

Boxing/unboxing occurs when a value type (like a struct, int, long) is passed somewhere that accepts a reference type - such as object.

This occurs when you explicitly create a method that takes parameters of type object that will be passed value types. It also comes up when you use the older non-generic collections to store value types (typically primitives).

You will also see boxing occuring when you use String.Format() and pass primitives to it. This is because String.Format() accepts a params object[] - which results in boxing of the additional parameters in the call.

Using reflection to invoke methods can also result in boxing/unboxing, because the reflection APIs have no choice but to return object since the real type is not known at compile time (and the Reflection APIs cannot be generic).

The newer generic collections do not result in boxing/unboxing, and so are preferable to the older collections for this reason (eg ArrayList, Hashtable, etc). Not to mention they are typesafe.

You can avoid boxing concerns by changing methods that accept objects to be generic. For example:

public void string Decorate( object a ) // passing a value type results in boxing
{
   return a.ToString() + " Some other value";
}

vs:

public void string Decorate<T>( T a )
{
   return a.ToString() + " some other value";
}
LBushkin
+1  A: 

It happens all the time when people do not know what the implications are, simply don't care or sometimes one cannot help but accept boxing as the lesser evel.

Strongly typed datarows will box/unbox pretty much all the time when you access a value-type property. Also, using a value type as an interface reference will box it as well. Or getting a delegate from an instance method of a value type. (The delegate's target is of type Object)

Robert Giesecke
+2  A: 

Here is a really nasty one :)

SqlCommand cmd = <a command that returns a scalar value stored as int>;

// This code works very well.
int result = (int)cmd.ExecuteScalar();

// This code will throw an exception.
uint result = (uint)cmd.ExecuteScalar();

The second execute fails because it tries to unbox an Int32 into an UInt32 which is not possible. So you have to unbox first and than cast.

uint result = (uint)(int)cmd.ExecuteScalar();
Alex
+1 for providing an example
chikak